Skip to content

Commit bd658a6

Browse files
authored
Accept all loaders in dbal transactional loader (#1849)
* Accept all loaders in dbal transactional loader * Updated DSL definitions
1 parent 076032b commit bd658a6

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/TransactionalDbalLoader.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ final class TransactionalDbalLoader implements Loader
1515
private TransactionIsolationLevel|int|null $isolationLevel = null;
1616

1717
/**
18-
* @var array<DbalLoader>
18+
* @var array<Loader>
1919
*/
2020
private readonly array $loaders;
2121

2222
/**
2323
* @param array<string, mixed> $connectionParams
24-
* @param DbalLoader ...$loaders
24+
* @param Loader ...$loaders
2525
*/
2626
public function __construct(
2727
private readonly array $connectionParams,
28-
DbalLoader ...$loaders,
28+
Loader ...$loaders,
2929
) {
3030
if (\count($loaders) === 0) {
3131
throw new InvalidArgumentException('At least one loader must be provided');
@@ -40,7 +40,7 @@ public function __construct(
4040
*/
4141
public static function fromConnection(
4242
Connection $connection,
43-
DbalLoader ...$loaders,
43+
Loader ...$loaders,
4444
) : self {
4545
$loader = new self($connection->getParams(), ...$loaders);
4646
$loader->connection = $connection;

src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/functions.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,14 +332,14 @@ function postgresql_update_options(
332332
* If any loader fails, the entire batch will be rolled back.
333333
*
334334
* @param array<string, mixed>|Connection $connection
335-
* @param DbalLoader ...$loaders - DBAL loaders to execute within the transaction
335+
* @param Loader ...$loaders - Loaders to execute within the transaction
336336
*
337337
* @throws InvalidArgumentException
338338
*/
339339
#[DocumentationDSL(module: Module::DOCTRINE, type: DSLType::LOADER)]
340340
function to_dbal_transaction(
341341
array|Connection $connection,
342-
DbalLoader ...$loaders,
342+
Loader ...$loaders,
343343
) : TransactionalDbalLoader {
344344
return \is_array($connection)
345345
? new TransactionalDbalLoader($connection, ...$loaders)

web/landing/resources/dsl.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)