Fix global phpstan errors (#1350)

* Added missing path to libs to rector configuration

* Fixed phpstan globally ignored errors

* Updated DSL

* More CS Fixes

* Build docs

Author: norberttech

.php-cs-fixer.php

@@ -22,6 +22,9 @@
         __DIR__ . '/web/**/tests',
         __DIR__ . '/examples',
         __DIR__ . '/tools/rector/src',
+    ])
+    ->exclude([
+        __DIR__ . '/src/lib/parquet/src/Flow/Parquet/Thrift'
     ]);
 
 if (!\file_exists(__DIR__ . '/var')) {
@@ -146,6 +149,8 @@
         'ternary_to_null_coalescing' => true,
         'yoda_style' => false,
         'void_return' => true,
+        'fully_qualified_strict_types' => false,
+        'phpdoc_array_type' => true,
         'php_unit_method_casing' => ['case' => 'snake_case'],
         'php_unit_test_case_static_method_calls' => ['call_type' => 'static'],
     ])

composer.json

@@ -386,7 +386,9 @@
             "tools/cs-fixer/vendor/bin/php-cs-fixer fix --dry-run"
         ],
         "cs:php:fix": [
-            "tools/cs-fixer/vendor/bin/php-cs-fixer fix"
+            "tools/cs-fixer/vendor/bin/php-cs-fixer fix",
+            "./tools/rector/vendor/bin/rector -c ./rector.src.php",
+            "./tools/rector/vendor/bin/rector -c ./rector.tests.php"
         ],
         "build:phar": [
             "composer update --working-dir=./src/cli",

phpstan.neon

@@ -3,6 +3,18 @@ parameters:
     treatPhpDocTypesAsCertain: false
     ignoreErrors:
         - identifier: argument.type
+          paths:
+            - src/core/etl/tests/*
+            - src/bridge/filesystem/azure/tests/*
+            - src/bridge/filesystem/async-aws/tests/*
+            - src/adapter/etl-adapter-xml/tests/*
+            - src/adapter/etl-adapter-text/tests/*
+            - src/adapter/etl-adapter-parquet/tests/*
+            - src/adapter/etl-adapter-meilisearch/tests/*
+            - src/adapter/etl-adapter-logger/tests/*
+            - src/adapter/etl-adapter-json/tests/*
+            - src/adapter/etl-adapter-http/tests/*
+            -  src/adapter/etl-adapter-csv/tests/*
         - identifier: missingType.iterableValue
     bootstrapFiles:
         - tools/phpunit/vendor/autoload.php

rector.src.php

@@ -9,10 +9,12 @@
         __DIR__ . '/examples',
         __DIR__ . '/src/core/etl/src',
         __DIR__ . '/src/cli/src',
+        __DIR__ . '/src/lib/*/src',
         __DIR__ . '/src/adapter/*/src',
         __DIR__ . '/src/bridge/*/*/src',
         __DIR__ . '/src/tools/*/*/src',
     ])
+    ->withSkipPath(__DIR__ . '/src/lib/parquet/src/Flow/Parquet/Thrift')
     ->withCache(__DIR__ . '/var/rector/src')
     ->withSets([
         LevelSetList::UP_TO_PHP_82

rector.tests.php

@@ -61,6 +61,7 @@
     ->withPaths([
         __DIR__ . '/src/core/etl/tests',
         __DIR__ . '/src/cli/tests',
+        __DIR__ . '/src/lib/*/tests',
         __DIR__ . '/src/adapter/*/tests',
         __DIR__ . '/src/bridge/*/*/tests',
         __DIR__ . '/src/tools/*/*/tests',
@@ -158,6 +159,7 @@
         RemoveParentCallWithoutParentRector::class
     ])
     ->withCache(__DIR__ . '/var/rector/tests')
+    ->withSkipPath(__DIR__ . '/src/lib/parquet/src/Flow/Parquet/Thrift')
     ->withImportNames(
         importNames: true,
         importDocBlockNames: true,

src/adapter/etl-adapter-elasticsearch/src/Flow/ETL/Adapter/Elasticsearch/EntryIdFactory/HashIdFactory.php

@@ -13,7 +13,7 @@
 final class HashIdFactory implements IdFactory
 {
     /**
-     * @var string[]
+     * @var array<string>
      */
     private readonly array $entryNames;
 

src/adapter/etl-adapter-google-sheet/src/Flow/ETL/Adapter/GoogleSheet/GoogleSheetExtractor.php

@@ -44,12 +44,12 @@ public function extract(FlowContext $context) : \Generator
         );
 
         /**
-         * @var array[] $values
+         * @var array<array> $values
          */
         $values = $response->getValues() ?? [];
 
         if ($this->withHeader && [] !== $values) {
-            /** @var string[] $headers */
+            /** @var array<string> $headers */
             $headers = $values[0];
             unset($values[0]);
             $totalRows = 1;
@@ -108,7 +108,7 @@ function (array $rowData) use ($headers, $shouldPutInputIntoRows) {
             /** @var Sheets\ValueRange $response */
             $response = $this->service->spreadsheets_values->get($this->spreadsheetId, $cellsRange->toString(), $this->options);
             /**
-             * @var array[] $values
+             * @var array<array> $values
              */
             $values = $response->getValues() ?? [];
         }

src/adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/RowsNormalizer/EntryNormalizer/PHPValueNormalizer.php

@@ -39,7 +39,7 @@ public function __construct(
     public function normalize(string $name, Type $type, mixed $value) : XMLNode|XMLAttribute
     {
         if (\str_starts_with($name, $this->attributePrefix)) {
-            return new XMLAttribute(\substr($name, \strlen($this->attributePrefix)), $this->caster->to(type_string())->value($value));
+            return new XMLAttribute(\substr($name, \strlen($this->attributePrefix)), (string) $this->caster->to(type_string())->value($value));
         }
 
         if ($value === null) {

src/adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/XMLWriter/DOMDocumentWriter.php

@@ -30,7 +30,7 @@ private function createDOMElement(\DOMDocument $dom, XMLNode $node) : \DOMElemen
         $element = $dom->createElement($node->name);
 
         if ($node->hasValue()) {
-            $element->appendChild($dom->createTextNode($node->value));
+            $element->appendChild($dom->createTextNode((string) $node->value));
         }
 
         foreach ($node->attributes as $attribute) {

src/adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/functions.php

@@ -44,7 +44,7 @@ function from_xml(
  * @param string $row_element_name - @deprecated use `withRowElementName()` method instead
  * @param string $attribute_prefix - @deprecated use `withAttributePrefix()` method instead
  * @param string $date_time_format - @deprecated use `withDateTimeFormat()` method instead
- * @param DOMDocumentWriter $xml_writer
+ * @param XMLWriter $xml_writer
  */
 #[DocumentationDSL(module: Module::XML, type: DSLType::LOADER)]
 function to_xml(