Add flowstorm.uiTimeoutMillis property to configure UI timeouts

Author: jpmonettas

CHANGELOG.md

@@ -8,6 +8,7 @@
 
     - Make :preview the default visualizer for numbers
     - Improved thread breakpoints UX/UI
+    - All api calls from UI have now a timeout, configurable via flowstorm.uiTimeoutMillis
               
 ### Bugs fixed
 

docs/user_guide.adoc

@@ -2219,6 +2219,7 @@ and possible values.
 - `-Dflowstorm.throwOnThreadLimit=true`
 - `-Dflowstorm.autoUpdateUI=false`
 - `-Dflowstorm.callTreeUpdate=false`
+- `-Dflowstorm.uiTimeoutMillis=4000`
 
 == Only Clojure
 

docs/user_guide.html

@@ -4346,6 +4346,9 @@ <h3 id="_clojure_and_clojurescript"><a class="anchor" href="#_clojure_and_clojur
 <li>
 <p><code>-Dflowstorm.callTreeUpdate=false</code></p>
 </li>
+<li>
+<p><code>-Dflowstorm.uiTimeoutMillis=4000</code></p>
+</li>
 </ul>
 </div>
 </div>
@@ -4830,7 +4833,7 @@ <h2 id="_internals_diagrams_and_documentation"><a class="anchor" href="#_interna
 </div>
 <div id="footer">
 <div id="footer-text">
-Last updated 2025-05-08 09:08:03 -0300
+Last updated 2025-05-09 13:05:50 -0300
 </div>
 </div>
 </body>

src-dbg/flow_storm/debugger/main.clj

@@ -66,6 +66,7 @@
         styles-prop (System/getProperty "flowstorm.styles")
         auto-update-ui-prop (System/getProperty "flowstorm.autoUpdateUI")
         call-tree-update-prop (System/getProperty "flowstorm.callTreeUpdate")
+        ui-timeout-millis (System/getProperty "flowstorm.uiTimeoutMillis")
         plugins-nss-set (->> (reduce-kv (fn [acc prop value]
                                           (if (str/starts-with? prop "flowstorm.plugins.namespaces")
                                             (into acc (str/split value #","))
@@ -78,6 +79,7 @@
       title-prop            (assoc :title  title-prop)
       auto-update-ui-prop   (assoc :auto-update-ui? (= "true" auto-update-ui-prop))
       call-tree-update-prop (assoc :call-tree-update? (= "true" call-tree-update-prop))
+      ui-timeout-millis     (assoc :ui-timeout-millis (Long/parseLong ui-timeout-millis))
       (seq plugins-nss-set) (assoc :plugins-namespaces-set plugins-nss-set))))
 
 (defn start-debugger

src-dbg/flow_storm/debugger/runtime_api.clj

@@ -28,8 +28,6 @@
 (declare rt-api)
 (declare api-call)
 
-(def api-call-timeout 4000)
-
 (def ^:dynamic *cache-disabled?* false)
 
 (defstate rt-api
@@ -134,8 +132,9 @@
   the callback will be called with the response. Otherwise it will block and return the response."
   ([call-type fkey args] (api-call call-type fkey args {} nil))
   ([call-type fkey args opts] (api-call call-type fkey args opts nil))
-  ([call-type fkey args {:keys [cache timeout] :or {timeout 5000}} callback]
-   (let [f (case call-type
+  ([call-type fkey args {:keys [cache]} callback]
+   (let [timeout (:ui-timeout-millis (dbg-state/debugger-config))
+         f (case call-type
              :local (dbg-api/api-fn-by-key fkey)
              :remote (fn [& args] (websocket/sync-remote-api-request fkey args)))
          debug-mode? (:debug-mode? (dbg-state/debugger-config))]
@@ -174,7 +173,7 @@
   RuntimeApiP
 
   (runtime-config [_] (api-call :local :runtime-config []))
-  (val-pprint [_ v opts] (api-call :local :val-pprint [v opts] {:cache api-cache :timeout api-call-timeout})) ;; CACHED
+  (val-pprint [_ v opts] (api-call :local :val-pprint [v opts] {:cache api-cache})) ;; CACHED
   (data-window-push-val-data [_ dw-id val-ref extra] (api-call :local :data-window-push-val-data [dw-id val-ref (config-dw-extras extra)]))
   (get-form [_ form-id] (api-call :local :get-form [form-id] {:cache api-cache}))  ;; CACHED
   (timeline-count [_ flow-id thread-id] (api-call :local :timeline-count [flow-id thread-id]))
@@ -323,7 +322,7 @@
   RuntimeApiP
 
   (runtime-config [_] (api-call :remote :runtime-config []))
-  (val-pprint [_ v opts] (api-call :remote :val-pprint [v opts] {:cache api-cache :timeout api-call-timeout})) ;; CACHED
+  (val-pprint [_ v opts] (api-call :remote :val-pprint [v opts] {:cache api-cache})) ;; CACHED
   (data-window-push-val-data [_ dw-id val-ref extra] (api-call :remote :data-window-push-val-data [dw-id val-ref (config-dw-extras extra)]))
   (get-form [_ form-id] (api-call :remote :get-form [form-id] {:cache api-cache}))  ;; CACHED
   (timeline-count [_ flow-id thread-id] (api-call :remote :timeline-count [flow-id thread-id]))

src-dbg/flow_storm/debugger/state.clj

@@ -174,6 +174,7 @@
 (s/def :config/debug-mode? boolean?)
 (s/def :config/auto-jump-on-exception? boolean?)
 (s/def :config/auto-update-ui? boolean?)
+(s/def :config/ui-timeout-millis number?)
 (s/def :config/pprint-previews? boolean?)
 
 (s/def ::debugger-config (s/keys :req-un [:config/repl
@@ -184,6 +185,7 @@
                                           :config/pprint-previews?
                                           :config/auto-jump-on-exception?
                                           :config/auto-update-ui?
+                                          :config/ui-timeout-millis
                                           :config/call-tree-update?]))
 
 (s/def :bookmark/id (s/tuple :flow/id :thread/id int?))
@@ -247,7 +249,7 @@
                                 ::bookmarks
                                 ::data-windows]))
 
-(defn initial-state [{:keys [theme styles local? port repl-type debugger-host ws-port runtime-host auto-update-ui? call-tree-update?] :as config}]
+(defn initial-state [{:keys [theme styles local? port repl-type debugger-host ws-port runtime-host auto-update-ui? ui-timeout-millis call-tree-update?] :as config}]
   {:flows {}
    :printers {}
    :selected-font-size-style-idx 0
@@ -277,6 +279,7 @@
                      :runtime-host (or runtime-host "localhost")
                      :debug-mode? false
                      :auto-jump-on-exception? false
+                     :ui-timeout-millis (or ui-timeout-millis 5000)
                      :auto-update-ui? (if-not (nil? auto-update-ui?) auto-update-ui? true)
                      :call-tree-update? (if-not (nil? call-tree-update?) call-tree-update? true)
                      :pprint-previews? false}