Skip to content

Commit 71c026f

Browse files
committed
Fix data windows default visualizers system
1 parent c8c7459 commit 71c026f

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
### Changes
88

99
### Bugs fixed
10+
11+
- Fix data windows default visualizers system
1012

1113
## 4.4.2 (13-05-2025)
1214

src-dbg/flow_storm/debugger/ui/data_windows/visualizers.clj

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@
1212
[java.util.concurrent.locks ReentrantLock]))
1313

1414
(defonce *visualizers (atom {}))
15-
(defonce *defaults-visualizers (atom []))
15+
16+
;; *defaults-visualizers should be a list (stack) and not a vector so
17+
;; the latest added take precedence and visualizers can be overwritten by users
18+
(defonce *defaults-visualizers (atom ()))
1619

1720
(defn register-visualizer [{:keys [id] :as viz}]
1821
(swap! *visualizers assoc id viz))
@@ -343,13 +346,15 @@
343346
;; Default visualizers ;;
344347
;;;;;;;;;;;;;;;;;;;;;;;;;
345348

349+
(add-default-visualizer (fn [val-data] (= "nil" (:flow-storm.runtime.values/type val-data))) :preview)
346350
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :paged-shallow-seqable)) :seqable)
347351
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :shallow-indexed)) :indexed)
348352
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :shallow-map)) :map)
353+
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :number)) :preview)
349354
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :int)) :int)
350355
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :string)) :preview)
351-
(add-default-visualizer (fn [val-data] (= "nil" (:flow-storm.runtime.values/type val-data))) :preview)
352-
(add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :number)) :preview)
356+
357+
353358

354359
;; Don't make this the default until we can make its render fast
355360
;; (add-default-visualizer (fn [val-data] (contains? (:flow-storm.runtime.values/kinds val-data) :byte-array)) :hex-byte-array)

0 commit comments

Comments
 (0)