Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Extension crashes if flow.trace.server is not a string #402

@jvilk-stripe

Description

@jvilk-stripe

Steps to reproduce

  1. Add flow.trace.server: null to your VS Code settings.
  2. Restart VS Code.
  3. Open a JS file. Flow will fail to start. The log shows a type error in fromString.

Expected result

Flow ignores the invalid setting.

The issue appears to be in the LanguageClient library. From the minified source, I cannot tell if it has been fixed upstream:

https://github.com/microsoft/vscode-languageserver-node/blob/084c035af6aeb2999df7d26eb69f3b34acae9ca8/client/src/common/client.ts#L3339

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions