fix: exec name alias should be respected when ws verb aliases are set (#324)

Fixes a bug where an executable's alias is not being added to the cache
when the workspace has verb overrides set.

Author: jahvon

internal/cache/executables_cache.go

@@ -277,6 +277,7 @@ func enumerateExecutableAliasRefs(
 ) executable.RefList {
 	refs := make(executable.RefList, 0)
 
+	// Always include explicit verb aliases defined on the executable itself
 	for _, v := range exec.VerbAliases {
 		if err := v.Validate(); err != nil {
 			continue
@@ -287,26 +288,30 @@ func enumerateExecutableAliasRefs(
 		}
 	}
 
+	// Always include name (ID) aliases for the executable's primary verb
+	for _, id := range exec.AliasesIDs() {
+		refs = append(refs, executable.NewRef(id, exec.Verb))
+	}
+
 	switch {
 	case override == nil:
-		// use default aliases
+		// use default aliases (related verbs for the primary verb)
 		for _, verb := range executable.RelatedVerbs(exec.Verb) {
 			refs = append(refs, executable.NewRef(exec.ID(), verb))
 			for _, id := range exec.AliasesIDs() {
 				refs = append(refs, executable.NewRef(id, verb))
 			}
 		}
 	case len(*override) == 0:
-		// disable all aliases if override is set but empty
-		return refs
+		// verb overrides explicitly disable verb aliases; keep only name aliases and explicit verb aliases
+		// nothing more to add
 	default:
 		// use overrides if provided
 		o := *override
 		if verbs, found := o[exec.Verb.String()]; found {
 			for _, v := range verbs {
 				vv := executable.Verb(v)
 				if err := vv.Validate(); err != nil {
-					// If the verb is not valid, skip it
 					continue
 				}
 				refs = append(refs, executable.NewRef(exec.ID(), vv))

internal/cache/executables_cache_test.go

@@ -270,6 +270,13 @@ var _ = Describe("ExecutableCacheImpl", func() {
 				Expect(err).NotTo(HaveOccurred())
 				Expect(exec).NotTo(BeNil())
 				Expect(exec.Name).To(Equal("test-alias"))
+
+				// And should still be able to access via name alias using the primary verb
+				aliasRunRef := executable.Ref("run test/testdata:alias1")
+				execFromAlias, err := execCache.GetExecutableByRef(aliasRunRef)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(execFromAlias).NotTo(BeNil())
+				Expect(execFromAlias.Name).To(Equal("test-alias"))
 			})
 		})