feat: allow nameless executables

jahvon · jahvon · commit 54b8c35814b4 · 2025-02-15T19:24:51.000-05:00
diff --git a/.github/workflows/analyze.yaml b/.github/workflows/analyze.yaml
@@ -23,7 +23,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Install Go Tools
         run: |
           go install go.uber.org/mock/mockgen@v0.4.0
@@ -50,7 +50,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
diff --git a/.github/workflows/codeql.yaml b/.github/workflows/codeql.yaml
@@ -22,7 +22,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3
         with:
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -27,7 +27,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Generate docs
         run: |
           go run ./tools/docsgen/.
@@ -52,7 +52,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
       - name: Login to GitHub Container Registry
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -24,7 +24,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Run Tests with Retries
         uses: nick-invision/retry@v3
         with:
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -17,8 +17,6 @@ linters-settings:
     enable-all: true
     disable:
       - fieldalignment # too strict
-  tenv:
-    all: true
 
 linters:
   disable-all: true
@@ -61,7 +59,7 @@ linters:
     - predeclared # finds code that shadows one of Go's predeclared identifiers
     - reassign # checks that package variables are not reassigned
     - stylecheck # is a replacement for golint
-    - tenv # detects using os.Setenv instead of t.Setenv since Go1.17
+    - usetesting # detects when some calls can be replaced by methods from the testing package
     - testableexamples # checks if examples are testable (have an expected output)
     - testpackage # makes you use a separate _test package
     - tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.4-bookworm
+FROM golang:1.24.1-bookworm
 
 ENV DISABLE_FLOW_INTERACTIVE="true"
 
diff --git a/cmd/internal/exec.go b/cmd/internal/exec.go
@@ -40,7 +40,7 @@ func RegisterExecCmd(ctx *context.Context, rootCmd *cobra.Command) {
 			io.TypesDocsURL("flowfile", "ExecutableRef"),
 			execExamples,
 		),
-		Args: cobra.MinimumNArgs(1),
+		Args: cobra.ArbitraryArgs,
 		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 			execList, err := ctx.ExecutableCache.GetExecutableList(ctx.Logger)
 			if err != nil {
@@ -82,8 +82,14 @@ func execFunc(ctx *context.Context, cmd *cobra.Command, verb executable.Verb, ar
 		logger.FatalErr(err)
 	}
 
-	idArg := args[0]
-	ref := context.ExpandRef(ctx, executable.NewRef(idArg, verb))
+	var ref executable.Ref
+	if len(args) == 0 {
+		ref = context.ExpandRef(ctx, executable.NewRef("", verb))
+	} else {
+		idArg := args[0]
+		ref = context.ExpandRef(ctx, executable.NewRef(idArg, verb))
+	}
+
 	e, err := ctx.ExecutableCache.GetExecutableByRef(logger, ref)
 	if err != nil && errors.Is(cache.NewExecutableNotFoundError(ref.String()), err) {
 		logger.Debugf("Executable %s not found in cache, syncing cache", ref)
@@ -108,7 +114,10 @@ func execFunc(ctx *context.Context, cmd *cobra.Command, verb executable.Verb, ar
 		))
 	}
 
-	execArgs := args[1:]
+	execArgs := make([]string, 0)
+	if len(args) >= 2 {
+		execArgs = args[1:]
+	}
 	envMap, err := argUtils.ProcessArgs(e, execArgs, nil)
 	if err != nil {
 		logger.FatalErr(err)
@@ -369,6 +378,14 @@ Flag arguments are specified with the format 'flag=value' and positional argumen
 `
 	execExamples = `
 #### Examples
+**Execute a nameless flow in the current workspace with the 'install' verb**
+
+flow install
+
+**Execute a nameless flow in the 'ws' workspace with the 'test' verb**
+
+flow test ws
+
 **Execute the 'build' flow in the current workspace and namespace**
 
 flow exec build
diff --git a/cmd/internal/library.go b/cmd/internal/library.go
@@ -46,6 +46,8 @@ func libraryFunc(ctx *context.Context, cmd *cobra.Command, _ []string) {
 	wsFilter := flags.ValueFor[string](ctx, cmd, *flags.FilterWorkspaceFlag, false)
 	if wsFilter == "." {
 		wsFilter = ctx.Config.CurrentWorkspace
+	} else if wsFilter == executable.WildcardWorkspace {
+		wsFilter = ""
 	}
 
 	nsFilter := flags.ValueFor[string](ctx, cmd, *flags.FilterNamespaceFlag, false)
@@ -55,7 +57,7 @@ func libraryFunc(ctx *context.Context, cmd *cobra.Command, _ []string) {
 		logger.PlainTextWarn("cannot use both --all and --namespace flags, ignoring --namespace")
 		fallthrough
 	case allNs:
-		nsFilter = "*"
+		nsFilter = executable.WildcardNamespace
 	case nsFilter == ".":
 		nsFilter = ctx.Config.CurrentNamespace
 	}
@@ -122,7 +124,7 @@ func glanceLibraryCmd(ctx *context.Context, cmd *cobra.Command, _ []string) {
 		logger.PlainTextWarn("cannot use both --all and --namespace flags, ignoring --namespace")
 		fallthrough
 	case allNs:
-		nsFilter = "*"
+		nsFilter = executable.WildcardNamespace
 	case nsFilter == ".":
 		nsFilter = ctx.Config.CurrentNamespace
 	}
@@ -188,7 +190,7 @@ func viewLibraryFunc(ctx *context.Context, cmd *cobra.Command, args []string) {
 		logger.FatalErr(err)
 	}
 	id := args[1]
-	ws, ns, name := executable.ParseExecutableID(id)
+	ws, ns, name := executable.MustParseExecutableID(id)
 	if ws == "" {
 		ws = ctx.CurrentWorkspace.AssignedName()
 	}
diff --git a/development.flow b/development.flow
@@ -2,9 +2,7 @@
 visibility: private
 tags: [development]
 executables:
-  - verb: run
-    name: checks
-    aliases: [precommit, pc, ci, validate]
+  - verb: validate
     description: |
       Run the repository validation checks. This includes linting, tests, and code generation.
       Validate should be run before committing changes.
diff --git a/docs/cli/flow_exec.md b/docs/cli/flow_exec.md
@@ -16,6 +16,14 @@ See https://flowexec.io/#/types/flowfile#ExecutableVerb for more information on
 
 
 #### Examples
+**Execute a nameless flow in the current workspace with the 'install' verb**
+
+flow install
+
+**Execute a nameless flow in the 'ws' workspace with the 'test' verb**
+
+flow test ws
+
 **Execute the 'build' flow in the current workspace and namespace**
 
 flow exec build
diff --git a/docs/schemas/flowfile_schema.json b/docs/schemas/flowfile_schema.json
@@ -33,7 +33,6 @@
       "description": "The executable schema defines the structure of an executable in the Flow CLI.\nExecutables are the building blocks of workflows and are used to define the actions that can be performed in a workspace.\n",
       "type": "object",
       "required": [
-        "name",
         "verb"
       ],
       "properties": {
@@ -53,7 +52,7 @@
           "$ref": "#/definitions/ExecutableLaunchExecutableType"
         },
         "name": {
-          "description": "The name of the executable. \n\nName is used to reference the executable in the CLI using the format `workspace:namespace/name`.\n[Verb group + Name] must be unique within the namespace of the workspace.\n",
+          "description": "The name of the executable. \n\nName is used to reference the executable in the CLI using the format `workspace/namespace:name`.\n[Verb group + Name] must be unique within the namespace of the workspace. \nName is required if the executable is defined within a namespace.\n",
           "type": "string",
           "default": ""
         },
@@ -307,7 +306,7 @@
       }
     },
     "ExecutableRef": {
-      "description": "A reference to an executable.\nThe format is `\u003cverb\u003e \u003cworkspace\u003e/\u003cnamespace\u003e:\u003cexecutable name\u003e`.\nFor example, `exec ws/ns:my-workflow`.\n\nThe workspace and namespace are optional.\nIf the workspace is not specified, the current workspace will be used.\nIf the namespace is not specified, the current namespace will be used.\n",
+      "description": "A reference to an executable.\nThe format is `\u003cverb\u003e \u003cworkspace\u003e/\u003cnamespace\u003e:\u003cexecutable name\u003e`.\nFor example, `exec ws/ns:my-workflow`.\n\n- If the workspace is not specified, the current workspace will be used.\n- If the namespace is not specified, the current namespace will be used.\n- Excluding the name will reference the executable with a matching verb but an unspecified name and namespace (e.g. `exec ws` or simply `exec`).\n",
       "type": "string"
     },
     "ExecutableRenderExecutableType": {
diff --git a/docs/schemas/template_schema.json b/docs/schemas/template_schema.json
@@ -46,7 +46,7 @@
       }
     },
     "ExecutableRef": {
-      "description": "A reference to an executable.\nThe format is `\u003cverb\u003e \u003cworkspace\u003e/\u003cnamespace\u003e:\u003cexecutable name\u003e`.\nFor example, `exec ws/ns:my-workflow`.\n\nThe workspace and namespace are optional.\nIf the workspace is not specified, the current workspace will be used.\nIf the namespace is not specified, the current namespace will be used.\n",
+      "description": "A reference to an executable.\nThe format is `\u003cverb\u003e \u003cworkspace\u003e/\u003cnamespace\u003e:\u003cexecutable name\u003e`.\nFor example, `exec ws/ns:my-workflow`.\n\n- If the workspace is not specified, the current workspace will be used.\n- If the namespace is not specified, the current namespace will be used.\n- Excluding the name will reference the executable with a matching verb but an unspecified name and namespace (e.g. `exec ws` or simply `exec`).\n",
       "type": "string"
     },
     "Field": {
diff --git a/docs/types/flowfile.md b/docs/types/flowfile.md
@@ -84,7 +84,7 @@ Executables are the building blocks of workflows and are used to define the acti
 | `description` | A description of the executable. This description is rendered as markdown in the interactive UI.  | `string` |  |  |
 | `exec` |  | [ExecutableExecExecutableType](#ExecutableExecExecutableType) | <no value> |  |
 | `launch` |  | [ExecutableLaunchExecutableType](#ExecutableLaunchExecutableType) | <no value> |  |
-| `name` | The name of the executable.   Name is used to reference the executable in the CLI using the format `workspace:namespace/name`. [Verb group + Name] must be unique within the namespace of the workspace.  | `string` |  | ✘ |
+| `name` | The name of the executable.   Name is used to reference the executable in the CLI using the format `workspace/namespace:name`. [Verb group + Name] must be unique within the namespace of the workspace.  Name is required if the executable is defined within a namespace.  | `string` |  |  |
 | `parallel` |  | [ExecutableParallelExecutableType](#ExecutableParallelExecutableType) | <no value> |  |
 | `render` |  | [ExecutableRenderExecutableType](#ExecutableRenderExecutableType) | <no value> |  |
 | `request` |  | [ExecutableRequestExecutableType](#ExecutableRequestExecutableType) | <no value> |  |
@@ -254,9 +254,9 @@ A reference to an executable.
 The format is `<verb> <workspace>/<namespace>:<executable name>`.
 For example, `exec ws/ns:my-workflow`.
 
-The workspace and namespace are optional.
-If the workspace is not specified, the current workspace will be used.
-If the namespace is not specified, the current namespace will be used.
+- If the workspace is not specified, the current workspace will be used.
+- If the namespace is not specified, the current namespace will be used.
+- Excluding the name will reference the executable with a matching verb but an unspecified name and namespace (e.g. `exec ws` or simply `exec`).
 
 
 **Type:** `string`
diff --git a/docs/types/template.md b/docs/types/template.md
@@ -49,9 +49,9 @@ A reference to an executable.
 The format is `<verb> <workspace>/<namespace>:<executable name>`.
 For example, `exec ws/ns:my-workflow`.
 
-The workspace and namespace are optional.
-If the workspace is not specified, the current workspace will be used.
-If the namespace is not specified, the current namespace will be used.
+- If the workspace is not specified, the current workspace will be used.
+- If the namespace is not specified, the current namespace will be used.
+- Excluding the name will reference the executable with a matching verb but an unspecified name and namespace (e.g. `exec ws` or simply `exec`).
 
 
 **Type:** `string`
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/jahvon/flow
 
-go 1.23
+go 1.24
 
 require (
 	github.com/Masterminds/sprig/v3 v3.3.0
diff --git a/internal/context/context.go b/internal/context/context.go
@@ -115,7 +115,7 @@ func (ctx *Context) String() string {
 		ws = "unk"
 	}
 	if ns == "" {
-		ns = "*"
+		ns = executable.WildcardNamespace
 	}
 	return fmt.Sprintf("%s/%s", ws, ns)
 }
@@ -170,8 +170,8 @@ func (ctx *Context) Finalize() {
 
 func ExpandRef(ctx *Context, ref executable.Ref) executable.Ref {
 	id := ref.ID()
-	ws, ns, name := executable.ParseExecutableID(id)
-	if ws == "" {
+	ws, ns, name := executable.MustParseExecutableID(id)
+	if ws == "" || ws == executable.WildcardWorkspace {
 		ws = ctx.CurrentWorkspace.AssignedName()
 	}
 	if ns == "" {
diff --git a/internal/io/library/init.go b/internal/io/library/init.go
@@ -60,7 +60,7 @@ func (l *Library) setVisibleExecs() {
 			if label == withoutNamespaceLabel {
 				curNs = ""
 			} else if label == allNamespacesLabel {
-				curNs = "*"
+				curNs = executable.WildcardNamespace
 			} else {
 				curNs = label
 			}
@@ -89,8 +89,13 @@ func (l *Library) setVisibleWorkspaces() {
 
 	filter := l.filter
 	filteredWs := l.allWorkspaces
-	if filter.Workspace != "" {
-		for _, ws := range l.allWorkspaces {
+	switch {
+	case filter.Workspace == "":
+		// do nothing
+	case filter.Workspace == allWorkspacesLabel || filter.Workspace == executable.WildcardWorkspace:
+		// do nothing
+	default:
+		for _, ws := range filteredWs {
 			if ws.AssignedName() == filter.Workspace {
 				filteredWs = workspace.WorkspaceList{ws}
 				break
@@ -122,11 +127,11 @@ func (l *Library) setVisibleNamespaces() {
 	for _, ex := range l.allExecutables {
 		ns := ex.Ref().Namespace()
 		ws := ex.Ref().Workspace()
-		if filter.Namespace != "*" && filter.Namespace != "" && ns != filter.Namespace {
+		if filter.Namespace != executable.WildcardNamespace && filter.Namespace != "" && ns != filter.Namespace {
 			continue
 		} else if filterWs != allWorkspacesLabel && filterWs != "" && ws != filterWs {
 			continue
-		} else if ns == "" || ns == "*" {
+		} else if ns == "" || ns == executable.WildcardNamespace {
 			someWithoutNs = true
 			continue
 		}
diff --git a/internal/io/library/library.go b/internal/io/library/library.go
@@ -90,7 +90,7 @@ func ctxVal(ws, ns string) string {
 		ws = "unk"
 	}
 	if ns == "" {
-		ns = "*"
+		ns = executable.WildcardNamespace
 	}
 	return fmt.Sprintf("%s/%s", ws, ns)
 }
diff --git a/types/executable/executable.gen.go b/types/executable/executable.gen.go
diff --git a/types/executable/executable.go b/types/executable/executable.go
diff --git a/types/executable/executable_schema.yaml b/types/executable/executable_schema.yaml
diff --git a/types/executable/ref.go b/types/executable/ref.go

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23.4-bookworm`
	`1`	`+FROM golang:1.24.1-bookworm`
`2`	`2`
`3`	`3`	`ENV DISABLE_FLOW_INTERACTIVE="true"`
`4`	`4`