fix(cli): force the tui when --output == tui (#331)

# Summary

Fixes an issue that prevents the TUI from showing when the user config
disables interactive mode but the output flag specifies `tui`. With this
change, the output format flag should always win over the config value.
The `DISABLE_FLOW_INTERACTIVE` env var is still the used to disable the
TUI with that flag set.

**Notable Changes**

- Removes `tui` as the default output format
- Respects the value of `--output=tui` when the user configs disables
the TUI

Closes #330

Author: jahvon

cmd/internal/flags/types.go

@@ -91,7 +91,7 @@ var OutputFormatFlag = &Metadata{
 	Name:      "output",
 	Shorthand: "o",
 	Usage:     "Output format. One of: yaml, json, or tui.",
-	Default:   "tui",
+	Default:   "",
 	Required:  false,
 }
 

cmd/internal/helpers.go

@@ -56,13 +56,18 @@ func MarkFlagFilename(_ *context.Context, cmd *cobra.Command, name string) {
 }
 
 func TUIEnabled(ctx *context.Context, cmd *cobra.Command) bool {
-	formatDisabled := false
 	if flags.HasFlag(cmd, *flags.OutputFormatFlag) {
 		format := flags.ValueFor[string](cmd, *flags.OutputFormatFlag, false)
-		formatDisabled = format == "yaml" || format == "yml" || format == "json"
+		if format == "yaml" || format == "yml" || format == "json" {
+			return false
+		}
+		if format == "tui" {
+			envDisabled, _ := strconv.ParseBool(os.Getenv(flowIO.DisableInteractiveEnvKey))
+			return !envDisabled
+		}
 	}
 	envDisabled, _ := strconv.ParseBool(os.Getenv(flowIO.DisableInteractiveEnvKey))
-	return !formatDisabled && !envDisabled && ctx.Config.ShowTUI()
+	return !envDisabled && ctx.Config.ShowTUI()
 }
 
 func SetView(ctx *context.Context, cmd *cobra.Command, view tuikit.View) {

docs/cli/flow_browse.md

@@ -24,7 +24,7 @@ flow browse [EXECUTABLE-REFERENCE] [flags]
   -h, --help                help for browse
   -l, --list                Show a simple list view of executables instead of interactive discovery.
   -n, --namespace string    Filter executables by namespace.
-  -o, --output string       Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string       Output format. One of: yaml, json, or tui.
   -t, --tag stringArray     Filter by tags.
   -v, --verb string         Filter executables by verb.
       --visibility string   Filter by visibility level (hierarchical). Valid: public, private, internal, hidden. Default: private

docs/cli/flow_cache_list.md

@@ -16,7 +16,7 @@ flow cache list [flags]
 
 ```
   -h, --help            help for list
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
 ```
 
 ### Options inherited from parent commands

docs/cli/flow_config_get.md

@@ -10,7 +10,7 @@ flow config get [flags]
 
 ```
   -h, --help            help for get
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
 ```
 
 ### Options inherited from parent commands

docs/cli/flow_logs.md

@@ -11,7 +11,7 @@ flow logs [flags]
 ```
   -h, --help            help for logs
       --last            Print the last execution's logs
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
 ```
 
 ### Options inherited from parent commands

docs/cli/flow_secret_list.md

@@ -10,7 +10,7 @@ flow secret list [flags]
 
 ```
   -h, --help            help for list
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
   -p, --plaintext       Output the secret value as plain text instead of an obfuscated string
 ```
 

docs/cli/flow_template_get.md

@@ -11,7 +11,7 @@ flow template get [flags]
 ```
   -f, --file string                  Path to the template file. It must be a valid flow file template.
   -h, --help                         help for get
-  -o, --output string                Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string                Output format. One of: yaml, json, or tui.
   -t, --template flow set template   Registered template name. Templates can be registered in the flow configuration file or with flow set template.
 ```
 

docs/cli/flow_template_list.md

@@ -10,7 +10,7 @@ flow template list [flags]
 
 ```
   -h, --help            help for list
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
 ```
 
 ### Options inherited from parent commands

docs/cli/flow_vault_get.md

@@ -10,7 +10,7 @@ flow vault get NAME [flags]
 
 ```
   -h, --help            help for get
-  -o, --output string   Output format. One of: yaml, json, or tui. (default "tui")
+  -o, --output string   Output format. One of: yaml, json, or tui.
 ```
 
 ### Options inherited from parent commands