Merge branch 'main' into temp-to-expr

Author: jahvon

.github/workflows/analyze.yaml

@@ -23,7 +23,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Install Go Tools
         run: |
           go install go.uber.org/mock/[email protected]
@@ -50,11 +50,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.60.3
+          version: v1.64.5
           args: --out-format=sarif:results.sarif,colored-line-number,github-actions
       - name: Upload SARIF file
         uses: github/codeql-action/upload-sarif@v3

.github/workflows/codeql.yaml

@@ -22,7 +22,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v3
         with:

.github/workflows/release.yaml

@@ -27,7 +27,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Generate docs
         run: |
           go run ./tools/docsgen/.
@@ -52,7 +52,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
       - name: Login to GitHub Container Registry

.github/workflows/test.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "^1.23"
+          go-version: "^1.24"
       - name: Run Tests with Retries
         uses: nick-invision/retry@v3
         with:

.golangci.yaml

@@ -17,8 +17,6 @@ linters-settings:
     enable-all: true
     disable:
       - fieldalignment # too strict
-  tenv:
-    all: true
 
 linters:
   disable-all: true
@@ -61,7 +59,7 @@ linters:
     - predeclared # finds code that shadows one of Go's predeclared identifiers
     - reassign # checks that package variables are not reassigned
     - stylecheck # is a replacement for golint
-    - tenv # detects using os.Setenv instead of t.Setenv since Go1.17
+    - usetesting # detects when some calls can be replaced by methods from the testing package
     - testableexamples # checks if examples are testable (have an expected output)
     - testpackage # makes you use a separate _test package
     - tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
@@ -94,6 +92,8 @@ issues:
         - gosec
         - noctx
         - wrapcheck
+    - linters: [gosec]
+      text: "G115"
     - linters:
         - staticcheck
       text: "SA5011" # SA5011: Should not use unsafe.Pointer - this throws false positives when a nil check does not result in a return

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.23.3-bookworm
+FROM golang:1.24.1-bookworm
 
 ENV DISABLE_FLOW_INTERACTIVE="true"
 

README.md

@@ -5,7 +5,6 @@
 <p align="center">
     <a href="https://img.shields.io/github/v/release/jahvon/flow"><img src="https://img.shields.io/github/v/release/jahvon/flow" alt="GitHub release"></a>
     <a href="https://pkg.go.dev/github.com/jahvon/flow"><img src="https://pkg.go.dev/badge/github.com/jahvon/flow.svg" alt="Go Reference"></a>
-    <a href="https://goreportcard.com/report/github.com/jahvon/flow"><img src="https://goreportcard.com/badge/github.com/jahvon/flow" alt="Go Report Card"></a>
 </p>
 
 <p align="center">

cmd/internal/exec.go

@@ -40,7 +40,7 @@ func RegisterExecCmd(ctx *context.Context, rootCmd *cobra.Command) {
 			io.TypesDocsURL("flowfile", "ExecutableRef"),
 			execExamples,
 		),
-		Args: cobra.MinimumNArgs(1),
+		Args: cobra.ArbitraryArgs,
 		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 			execList, err := ctx.ExecutableCache.GetExecutableList(ctx.Logger)
 			if err != nil {
@@ -82,8 +82,14 @@ func execFunc(ctx *context.Context, cmd *cobra.Command, verb executable.Verb, ar
 		logger.FatalErr(err)
 	}
 
-	idArg := args[0]
-	ref := context.ExpandRef(ctx, executable.NewRef(idArg, verb))
+	var ref executable.Ref
+	if len(args) == 0 {
+		ref = context.ExpandRef(ctx, executable.NewRef("", verb))
+	} else {
+		idArg := args[0]
+		ref = context.ExpandRef(ctx, executable.NewRef(idArg, verb))
+	}
+
 	e, err := ctx.ExecutableCache.GetExecutableByRef(logger, ref)
 	if err != nil && errors.Is(cache.NewExecutableNotFoundError(ref.String()), err) {
 		logger.Debugf("Executable %s not found in cache, syncing cache", ref)
@@ -108,12 +114,15 @@ func execFunc(ctx *context.Context, cmd *cobra.Command, verb executable.Verb, ar
 		))
 	}
 
-	execArgs := args[1:]
+	execArgs := make([]string, 0)
+	if len(args) >= 2 {
+		execArgs = args[1:]
+	}
 	envMap, err := argUtils.ProcessArgs(e, execArgs, nil)
 	if err != nil {
 		logger.FatalErr(err)
 	}
-	s, err := store.NewStore()
+	s, err := store.NewStore(store.Path())
 	if err != nil {
 		logger.FatalErr(err)
 	}
@@ -145,7 +154,7 @@ func execFunc(ctx *context.Context, cmd *cobra.Command, verb executable.Verb, ar
 		logger.FatalErr(err)
 	}
 	dur := time.Since(startTime)
-	processStore, err := store.NewStore()
+	processStore, err := store.NewStore(store.Path())
 	if err != nil {
 		logger.Errorf("failed clearing process store\n%v", err)
 	}
@@ -369,6 +378,14 @@ Flag arguments are specified with the format 'flag=value' and positional argumen
 `
 	execExamples = `
 #### Examples
+**Execute a nameless flow in the current workspace with the 'install' verb**
+
+flow install
+
+**Execute a nameless flow in the 'ws' workspace with the 'test' verb**
+
+flow test ws
+
 **Execute the 'build' flow in the current workspace and namespace**
 
 flow exec build

cmd/internal/flags/helpers.go

@@ -10,6 +10,7 @@ import (
 	"github.com/jahvon/flow/internal/context"
 )
 
+//nolint:errcheck
 func ToPflag(cmd *cobra.Command, metadata Metadata, persistent bool) (*pflag.FlagSet, error) {
 	flagSet := cmd.Flags()
 	if persistent {
@@ -108,5 +109,6 @@ func ValueFor[T any](ctx *context.Context, cmd *cobra.Command, metadata Metadata
 		logger.Fatalf("unexpected flag default type (%v)", reflect.TypeOf(metadata.Default).Kind())
 	}
 
+	//nolint:errcheck
 	return val.(T)
 }

cmd/internal/flags/helpers_test.go

@@ -71,6 +71,7 @@ var _ = Describe("ValueFor", func() {
 			Expect(err).NotTo(HaveOccurred())
 			cmd.Flags().AddFlagSet(flagset)
 			if reflect.TypeOf(expectedValue).Kind() == reflect.Slice {
+				//nolint:errcheck
 				err = cmd.ParseFlags([]string{"--test", expectedValue.([]string)[0]})
 			} else {
 				err = cmd.ParseFlags([]string{"--test=" + fmt.Sprintf("%v", expectedValue)})