Skip to content

Commit ecb17a5

Browse files
authored
chore: bump go verion (#327)
# Summary Bumps the project to Go version `1.25` which also requires using a newer `golanglint-ci`
1 parent af461e9 commit ecb17a5

File tree

9 files changed

+20
-16
lines changed

9 files changed

+20
-16
lines changed

.execs/tools.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ executables:
2828
- cmd: |
2929
if ! command -v golangci-lint &> /dev/null; then
3030
echo "golangci-lint is not installed. Installing..."
31-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s v2.2.2
31+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s v2.5.0
3232
fi
3333
- cmd: |
3434
if ! command -v ginkgo &> /dev/null; then

.execs/validate.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ executables:
5656
- cmd: |
5757
if ! command -v golangci-lint &> /dev/null; then
5858
echo "Installing golangci-lint..."
59-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s v2.1.6
59+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s v2.5.0
6060
export PATH="$PATH:./bin"
6161
fi
6262

.github/workflows/ci.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Go
2222
uses: actions/setup-go@v6
2323
with:
24-
go-version: "^1.24"
24+
go-version: "^1.25"
2525
- uses: flowexec/action@v1
2626
with:
2727
executable: 'lint go --param CI=true'
@@ -40,7 +40,7 @@ jobs:
4040
- name: Set up Go
4141
uses: actions/setup-go@v6
4242
with:
43-
go-version: "^1.24"
43+
go-version: "^1.25"
4444
- uses: flowexec/action@v1
4545
with:
4646
executable: 'test unit --param CI=true'
@@ -60,7 +60,7 @@ jobs:
6060
- name: Set up Go
6161
uses: actions/setup-go@v6
6262
with:
63-
go-version: "^1.24"
63+
go-version: "^1.25"
6464
- uses: flowexec/action@v1
6565
with:
6666
executable: 'test e2e --param CI=true'
@@ -107,7 +107,7 @@ jobs:
107107
- name: Set up Go
108108
uses: actions/setup-go@v6
109109
with:
110-
go-version: "^1.24"
110+
go-version: "^1.25"
111111
- name: Install mockgen
112112
run: go install go.uber.org/mock/[email protected]
113113
- uses: flowexec/action@v1
@@ -132,7 +132,7 @@ jobs:
132132
- name: Set up Go
133133
uses: actions/setup-go@v6
134134
with:
135-
go-version: "^1.24"
135+
go-version: "^1.25"
136136
- uses: flowexec/action@v1
137137
with:
138138
executable: 'build binary'
@@ -151,7 +151,7 @@ jobs:
151151
- name: Set up Go
152152
uses: actions/setup-go@v6
153153
with:
154-
go-version: "^1.24"
154+
go-version: "^1.25"
155155
- uses: flowexec/action@v1
156156
with:
157157
executable: 'scan security'

.github/workflows/codeql.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
- name: Set up Go
2323
uses: actions/setup-go@v6
2424
with:
25-
go-version: "^1.24"
25+
go-version: "^1.25"
2626
- name: Initialize CodeQL
2727
uses: github/codeql-action/init@v3
2828
with:

.github/workflows/release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
- name: Set up Go
2828
uses: actions/setup-go@v6
2929
with:
30-
go-version: "^1.24"
30+
go-version: "^1.25"
3131
- name: Generate docs
3232
run: |
3333
go run ./tools/docsgen/.
@@ -52,7 +52,7 @@ jobs:
5252
- name: Set up Go
5353
uses: actions/setup-go@v6
5454
with:
55-
go-version: "^1.24"
55+
go-version: "^1.25"
5656
- name: Set up QEMU
5757
uses: docker/setup-qemu-action@v3
5858
- name: Set up Docker Buildx

.golangci.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ linters:
103103
- funlen
104104
- gocognit
105105
- gocyclo
106+
# TODO: switch exec.Command usage to CommandContext
107+
- linters:
108+
- noctx
109+
text: "os/exec.Command must not be called. use os/exec.CommandContext"
106110
paths:
107111
- third_party$
108112
- builtin$

CLAUDE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ flow/
3232
## Key Technologies & Frameworks
3333

3434
### Go CLI Application
35-
- **Language**: Go 1.24+ (see go.mod:3)
35+
- **Language**: Go 1.25+ (see go.mod:3)
3636
- **CLI Framework**: Cobra (github.com/spf13/cobra)
3737
- **TUI Framework**: Custom tuikit (github.com/flowexec/tuikit) based on github.com/charmbracelet/bubbletea
3838
- **Testing**: Ginkgo BDD framework (github.com/onsi/ginkgo/v2)
@@ -84,14 +84,14 @@ The project heavily uses code generation:
8484
## Configuration Files
8585

8686
- **flow.yaml**: Workspace configuration for the flow repo itself
87-
- **go.mod**: Go dependencies and version (Go 1.24+)
87+
- **go.mod**: Go dependencies and version (Go 1.25+)
8888
- **desktop/package.json**: Node.js dependencies for desktop app
8989
- **desktop/src-tauri/tauri.conf.json**: Tauri desktop app configuration
9090
- **.execs/**: flow development workflows (executables)
9191

9292
## Development Setup
9393

94-
1. **Prerequisites**: Go 1.24+, flow CLI installed
94+
1. **Prerequisites**: Go 1.25+, flow CLI installed
9595
2. **Setup**: `flow workspace add flow . --set`
9696
3. **Dependencies**: `flow install tools`
9797
4. **Verification**: `flow validate`

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.25.1-bookworm
1+
FROM golang:1.25.2-bookworm
22

33
ENV DISABLE_FLOW_INTERACTIVE="true"
44

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/flowexec/flow
22

3-
go 1.24.6
3+
go 1.25
44

55
require (
66
github.com/atotto/clipboard v0.1.4

0 commit comments

Comments
 (0)