Backend: rename the authentication errors to be more generic.

Author: paveloom

backend/db/session.go

@@ -12,8 +12,8 @@ import (
 )
 
 var (
-	AuthenticateErrCredentials = errors.New("invalid credentials")
-	AuthenticateErrQuery       = errors.New("failed to query the user")
+	Unathorized         = errors.New("unauthorized")
+	InternalServerError = errors.New("internal server error")
 )
 
 func Authenticate(username string, password string) (int, error) {
@@ -24,15 +24,15 @@ func Authenticate(username string, password string) (int, error) {
 	err := db.QueryRow(query, username).Scan(&userID, &hashedPassword)
 	if err != nil {
 		if err == sql.ErrNoRows {
-			return -1, AuthenticateErrCredentials
+			return -1, Unathorized
 		}
 		log.Println(err)
-		return -1, AuthenticateErrQuery
+		return -1, InternalServerError
 	}
 
 	err = bcrypt.CompareHashAndPassword([]byte(hashedPassword), []byte(password))
 	if err != nil {
-		return -1, AuthenticateErrCredentials
+		return -1, Unathorized
 	}
 
 	return userID, nil

backend/server/session.go

@@ -30,10 +30,10 @@ func (handler *sessionHandler) handlePost(writer http.ResponseWriter, request *h
 	}
 
 	userID, err := db.Authenticate(credentials.Username, credentials.Password)
-	if err == db.AuthenticateErrCredentials {
+	if err == db.Unathorized {
 		http.Error(writer, err.Error(), http.StatusUnauthorized)
 		return
-	} else if err == db.AuthenticateErrQuery {
+	} else if err == db.InternalServerError {
 		http.Error(writer, err.Error(), http.StatusInternalServerError)
 		return
 	}