!!! Make getServiceType() a static function

This change makes OAuthController::getServiceType() a static public
function and therefore requires implementations which sub class
OAuthController to be adjusted accordingly. It is changed in order to
allow PHP 8 based applications detect service types properly in
`OAuthController` without having to instantiate all client
implementations.

Resolves #28

Author: robertlemke

Classes/Controller/OAuthController.php

@@ -95,7 +95,7 @@ protected static function detectServiceTypes(ObjectManagerInterface $objectManag
             if ($reflectionService->isClassAbstract($serviceTypeClassName)) {
                 continue;
             }
-            $serviceType = call_user_func_array([$serviceTypeClassName, 'getServiceType'], []);
+            $serviceType = $serviceTypeClassName::getServiceType();
             $serviceTypes[$serviceType] = $serviceTypeClassName;
         }
         return $serviceTypes;

Classes/OAuthClient.php

@@ -132,7 +132,7 @@ public function injectEntityManager(EntityManagerInterface $entityManager): void
      *
      * @return string For example, "Github", "oidc", ...
      */
-    abstract public function getServiceType(): string;
+    abstract public static function getServiceType(): string;
 
     /**
      * Returns the service name, i.e. something like an instance name of the concrete implementation of this client

Tests/Unit/Fixtures/OAuthTestClient.php

@@ -21,7 +21,7 @@ final class OAuthTestClient extends OAuthClient
     public const TEST_BASE_URI = 'https://localbeach.net/';
     public const TEST_CLIENT_ID = 'my-client-id';
 
-    public function getServiceType(): string
+    public static function getServiceType(): string
     {
         return self::TEST_SERVICE_TYPE;
     }

composer.json

@@ -14,7 +14,14 @@
     "support": {
         "email": "[email protected]"
     },
+    "funding": [
+        {
+            "type": "github",
+            "url": "https://github.com/sponsors/robertlemke"
+        }
+    ],
     "require": {
+        "php": "^7.4 || ^8.0",
         "neos/flow": "^6.0 || ^7.0 || dev-master",
         "guzzlehttp/guzzle": "^6.3",
         "league/oauth2-client": "^2.0",
@@ -49,4 +56,4 @@
             "Neos.Flow-20201207104500"
         ]
     }
-}
+}