Merge pull request #7 from hphoeksma/bufgix-wrong-servicetype-pointer

kdambekalns · web-flow · commit f1fe73067c50 · 2021-09-16T17:57:55.000+02:00
Fix client creation by using the type reference
diff --git a/Classes/Controller/OAuthController.php b/Classes/Controller/OAuthController.php
@@ -45,7 +45,7 @@ public function startAuthorizationAction(string $clientId, string $clientSecret,
             throw new OAuthClientException(sprintf('Failed starting OAuth2 authorization, because the given service type "%s" is unknown.', $serviceType), 1511187873921);
         }
 
-        $client = new $this->serviceTypes[$serviceName]($serviceName);
+        $client = new $this->serviceTypes[$serviceType]($serviceName);
         assert($client instanceof OAuthClient);
         $authorizeUri = $client->startAuthorization($clientId, $clientSecret, $returnToUri, $scope);
         $this->redirectToUri($authorizeUri);

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function startAuthorizationAction(string $clientId, string $clientSecret,`
`45`	`45`	`throw new OAuthClientException(sprintf('Failed starting OAuth2 authorization, because the given service type "%s" is unknown.', $serviceType), 1511187873921);`
`46`	`46`	`}`
`47`	`47`
`48`		`- $client = new $this->serviceTypes[$serviceName]($serviceName);`
	`48`	`+ $client = new $this->serviceTypes[$serviceType]($serviceName);`
`49`	`49`	`assert($client instanceof OAuthClient);`
`50`	`50`	`$authorizeUri = $client->startAuthorization($clientId, $clientSecret, $returnToUri, $scope);`
`51`	`51`	`$this->redirectToUri($authorizeUri);`