improved coverage

Author: flrdv

http/response_test.go

@@ -1,6 +1,7 @@
 package http
 
 import (
+	"io"
 	"testing"
 
 	"github.com/indigo-web/indigo/kv"
@@ -18,3 +19,21 @@ func TestResponse(t *testing.T) {
 		require.Equal(t, "application/json", contentType)
 	})
 }
+
+func TestSliceReader(t *testing.T) {
+	var message []byte
+	r := &sliceReader{data: []byte("Hello, world!")}
+	buff := make([]byte, 5)
+
+	for {
+		n, err := r.Read(buff)
+		message = append(message, buff[:n]...)
+		switch err {
+		case nil:
+		case io.EOF:
+			return
+		default:
+			require.Fail(t, err.Error())
+		}
+	}
+}

http/status/codes_test.go

@@ -25,3 +25,9 @@ func Benchmark(b *testing.B) {
 		_ = StringCode(code)
 	}
 }
+
+func TestString(t *testing.T) {
+	require.Equal(t, "Nonstandard", String(1))
+	require.Equal(t, "OK", String(200))
+	require.Equal(t, "Nonstandard", String(maxCodeValue))
+}

internal/buffer/buffer_test.go

@@ -94,6 +94,16 @@ func TestBuffer(t *testing.T) {
 		testTrunc(t, 1)
 		testTrunc(t, 5)
 	})
+
+	t.Run("by single byte", func(t *testing.T) {
+		buff := New(5, 5)
+		for range 5 {
+			require.True(t, buff.AppendByte('a'))
+		}
+
+		require.False(t, buff.AppendByte('a'))
+		require.Equal(t, "aaaaa", string(buff.Finish()))
+	})
 }
 
 func testDiscard(t *testing.T, n int) {

internal/codecutil/cache_test.go

@@ -0,0 +1,45 @@
+package codecutil
+
+import (
+	"testing"
+
+	"github.com/indigo-web/indigo/http/codec"
+	"github.com/stretchr/testify/require"
+)
+
+type mockCodec struct {
+	Instantiated bool
+}
+
+func (m *mockCodec) Token() string {
+	return "mock"
+}
+
+func (m *mockCodec) New() codec.Instance {
+	m.Instantiated = true
+	return nil
+}
+
+func TestLazyInstantiation(t *testing.T) {
+	mock := new(mockCodec)
+	cache := NewCache([]codec.Codec{mock}, "")
+	require.False(t, mock.Instantiated)
+	_ = cache.Get("rand")
+	require.False(t, mock.Instantiated)
+	_ = cache.Get("mock")
+	require.True(t, mock.Instantiated)
+}
+
+func TestAcceptEncoding(t *testing.T) {
+	t.Run("0", func(t *testing.T) {
+		require.Equal(t, "identity", AcceptEncoding([]codec.Codec{}))
+	})
+
+	t.Run("1", func(t *testing.T) {
+		require.Equal(t, "gzip", AcceptEncoding([]codec.Codec{codec.NewGZIP()}))
+	})
+
+	t.Run("2", func(t *testing.T) {
+		require.Equal(t, "gzip, zstd", AcceptEncoding([]codec.Codec{codec.NewGZIP(), codec.NewZSTD()}))
+	})
+}

router/inbuilt/static_test.go

@@ -0,0 +1,26 @@
+package inbuilt
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestSafePath(t *testing.T) {
+	for _, tc := range []string{
+		"/",
+		"/./",
+		"/./.",
+		"././.",
+	} {
+		require.True(t, isSafe(tc))
+	}
+
+	for _, tc := range []string{
+		"/..",
+		"../",
+		"/../",
+	} {
+		require.False(t, isSafe(tc))
+	}
+}