Skip to content

using the concat plugin with CRI logs ends up deleting the stream key from the recordΒ #116

@mmerickel

Description

@mmerickel

What is the purpose of dropping the stream key when combining records? It seems intentional as part of comments made in cb96cc7 but I can't see why.

Further, the example linked and used in tests doesn't make any sense that a partial message would not have the same stream value across the partials. You should think that each stream would be concatenated individually and then the stream tag preserved.

This issue is very similar to fluent/fluent-bit#4387 where they are also parsing it incorrectly, It would be nice if fluentd-concat would get this right. You can see the example in this linked issue below and will be parsed incorrectly by the concat plugin.

2021-11-18T14:47:34.730832241+00:00 stdout F some short log message A
2021-11-18T14:47:34.730832241+00:00 stdout P some longer log message B part one
2021-11-18T14:47:34.730908438+00:00 stdout F end of the longer message B
2021-11-18T14:47:34.730908438+00:00 stdout P another longer log message  C part one
2021-11-18T14:47:34.730939216+00:00 stdout P message C continued in part two
2021-11-18T14:47:34.735454549+00:00 stderr F some log message D in stderr part one
2021-11-18T14:47:34.735482854+00:00 stdout F message C still continued after a line from a different stream
2021-11-18T14:47:34.735482854+00:00 stderr F and the end of the stderr message D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions