Skip to content

Commit 016e9a2

Browse files
esmerelcnorris-cs
andauthored
Apply suggestions from code review
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: esmerel <[email protected]>
1 parent 7f7df1a commit 016e9a2

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

installation/windows.md

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ PS> Get-FileHash fluent-bit-3.2.4-win32.exe
118118
1. Download a ZIP archive. Choose the suitable installers for your 32-bit or 64-bit
119119
environments.
120120

121-
1. Expand the ZIP archive. You can do this by clicking "Extract All" in Explorer
121+
1. Expand the ZIP archive. You can do this by clicking **Extract All** in Explorer
122122
or `Expand-Archive` in PowerShell.
123123

124124
```text
@@ -144,7 +144,7 @@ PS> Get-FileHash fluent-bit-3.2.4-win32.exe
144144
└── fluent-bit.h
145145
```
146146

147-
1. Launch `cmd.exe` or PowerShell on your machine, and execute `fluent-bit.exe`:.
147+
1. Launch `cmd.exe` or PowerShell on your machine, and execute `fluent-bit.exe`:
148148

149149
```text
150150
PS> .\bin\fluent-bit.exe -i dummy -o stdout
@@ -171,7 +171,7 @@ Fluent Bit v2.0.x
171171
[3] dummy.0: [1561684388.441405800, {"message"=>"dummy"}]
172172
```
173173

174-
To halt the process, press `CTRL-C` in the terminal.
174+
To halt the process, press `Control+C` in the terminal.
175175

176176
## Installing from the EXE installer
177177

@@ -181,7 +181,7 @@ To halt the process, press `CTRL-C` in the terminal.
181181
![Installation wizard screenshot](<../.gitbook/assets/windows\_installer (1) (1).png>)
182182

183183
1. Click **Next** and finish the installation. By default, Fluent Bit is installed
184-
into `C:\Program Files\fluent-bit\`.
184+
in `C:\Program Files\fluent-bit\`.
185185

186186
You should be able to launch Fluent Bit using the following PowerShell command:.
187187

@@ -209,7 +209,7 @@ This can be used for provisioning with automation like Ansible, Puppet, and so o
209209

210210
Windows services are equivalent to daemons in UNIX (long-running background
211211
processes).
212-
For v1.5.0 and later, Fluent Bit has native support for Windows service.
212+
For v1.5.0 and later, Fluent Bit has native support for Windows services.
213213

214214
For example, you have the following installation layout:
215215

@@ -243,7 +243,7 @@ SERVICE_NAME: fluent-bit
243243
...
244244
```
245245

246-
To halt the Fluent Bit service, execute the `stop` command.
246+
To halt the Fluent Bit service, use the `stop` command.
247247

248248
```text
249249
sc.exe stop fluent-bit
@@ -259,7 +259,7 @@ sc.exe config fluent-bit start= auto
259259

260260
### Fluent Bit fails to start up when installed under `C:\Program Files`
261261

262-
Quotations are required if file paths contain spaces. Here is an example:
262+
Quotations are required if file paths contain spaces. For example:
263263

264264
```text
265265
sc.exe create fluent-bit binpath= "\"C:\Program Files\fluent-bit\bin\fluent-bit.exe\" -c \"C:\Program Files\fluent-bit\conf\fluent-bit.conf\""
@@ -310,13 +310,13 @@ PS> Remove-Service fluent-bit
310310

311311
## Compile from Source
312312

313-
If you need to create a custom executable, you can use the following procedure to
313+
If you need to create a custom executable, use the following procedure to
314314
compile Fluent Bit by yourself.
315315

316316
### Preparation
317317

318318
1. Install Microsoft Visual C++ to compile Fluent Bit. You can install the minimum
319-
toolkit using the following command:
319+
toolkit using the following command:
320320

321321
```text
322322
PS> wget -o vs.exe https://aka.ms/vs/16/release/vs_buildtools.exe
@@ -325,7 +325,8 @@ PS> start vs.exe
325325

326326
1. Choose `C++ Build Tools` and `C++ CMake tools for Windows` and wait until the process finishes.
327327

328-
1. Install flex and bison. One way to install them on Windows is to use [winflexbison](https://github.com/lexxmark/winflexbison).
328+
1. Install flex and bison. One way to install them on Windows is to use
329+
[winflexbison](https://github.com/lexxmark/winflexbison).
329330

330331
```text
331332
PS> wget -o winflexbison.zip https://github.com/lexxmark/winflexbison/releases/download/v2.5.22/win_flex_bison-2.5.22.zip
@@ -351,8 +352,8 @@ PS> start vs.exe
351352
1. Open the **Start menu** on Windows and type `command Prompt for VS`. From the result
352353
list, select the one that corresponds to your target system ( `x86` or `x64`).
353354

354-
1. Check that the installed OpenSSL library files match the selected target. You can
355-
check the library files by using the `dumpbin` command with the `/headers`
355+
1. Verify the installed OpenSSL library files match the selected target. You can
356+
examine the library files by using the `dumpbin` command with the `/headers`
356357
option .
357358

358359
1. Clone the source code of Fluent Bit.

0 commit comments

Comments
 (0)