Skip to content

Commit 0344c13

Browse files
authored
Merge pull request #1637 from fluent/lynettemiles/sc-135372/set-exclamation-vale-test-to-error-for-fluent
2 parents f2cfb13 + 1e957df commit 0344c13

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@ at the `suggestion` level and won't block merging.
128128

129129
The following tests are at a `error` level and will prevent merging:
130130

131+
- [Emdash](https://github.com/errata-ai/Google/blob/master/Google/EmDash.yml)
132+
- [Endash](https://github.com/errata-ai/Google/blob/master/Google/EmDash.yml)
133+
- [Exclamation](https://github.com/errata-ai/Google/blob/master/Google/Exclamation.yml)
131134
- [NonStandardQuotes](https://github.com/fluent/fluent-bit-docs/blob/master/vale-styles/FluentBit/NonStandardQuotes.yml):
132135
[Use standard quotes](https://developers.google.com/style/quotation-marks#straight-and-curly-quotation-marks).
133136
By default, Google Docs and Microsoft Word turn standard straight quotes into "smart"

SUMMARY.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@
230230
* [Getting Started](stream-processing/getting-started/README.md)
231231
* [Fluent Bit + SQL](stream-processing/getting-started/fluent-bit-sql.md)
232232
* [Check Keys and NULL values](stream-processing/getting-started/check-keys-null-values.md)
233-
* [Hands On! 101](stream-processing/getting-started/hands-on.md)
233+
* [Hands On 101](stream-processing/getting-started/hands-on.md)
234234

235235
## Fluent Bit for Developers <a href="#development" id="development"></a>
236236

pipeline/filters/kubernetes.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,8 +405,6 @@ spec:
405405

406406
The key point is to set `hostNetwork` to `true` and `dnsPolicy` to `ClusterFirstWithHostNet` that fluent bit DaemonSet could call Kubelet locally. Otherwise it could not resolve the dns for kubelet.
407407

408-
Now you are good to use this new feature!
409-
410408
### Verify that the Use\_Kubelet option is working
411409

412410
Basically you should see no difference about your experience for enriching your log files with Kubernetes metadata.

vale-styles/FluentBit/Exclamation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ extends: existence
22
message: "Don't use exclamation points in text."
33
link: 'https://developers.google.com/style/exclamation-points'
44
nonword: true
5-
level: suggestion
5+
level: error
66
tokens:
77
- '\w!(?:\s|$)'

0 commit comments

Comments
 (0)