Skip to content

Conversation

@pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Jul 26, 2023

This adds documentation for the new in_mem_metrics plugin: fluent/fluent-bit#7615.

This adds documentation for the new `in_mem_metrics` plugin: fluent/fluent-bit#7615.

Signed-off-by: Phillip Whelan <[email protected]>
@pwhelan pwhelan self-assigned this Jul 26, 2023
@pwhelan
Copy link
Contributor Author

pwhelan commented Jul 26, 2023

@patrick-stephens should I add a specific example for using docker to log metrics for kubernetes nodes?

@patrick-stephens
Copy link
Contributor

@patrick-stephens should I add a specific example for using docker to log metrics for kubernetes nodes?

I don't really understand so probably :)

Although why would you use it over node exporter, kubelet metrics, etc. is probably the main question I'd have? Be good to have an example of what it provides in addition.

@pwhelan
Copy link
Contributor Author

pwhelan commented Jul 26, 2023

Although why would you use it over node exporter, kubelet metrics, etc. is probably the main question I'd have? Be good to have an example of what it provides in addition.

The main reason to use it over those options is granularity. This plugin grabs the memory usage of each individual process and various different types, ie: shared, etc... If you want to be able to correctly diagnose which process is actually leaking this would be what you need to be able to discern that correctly.

@lecaros lecaros requested review from a team as code owners March 25, 2025 14:34
@eschabell eschabell requested review from esmerel and removed request for ehienabs October 22, 2025 19:00
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 22, 2025
@eschabell
Copy link
Collaborator

@esmerel would you give this a docs review please? Still waiting on code merge PR fluent/fluent-bit#7615, but I've given that a nudge.

@eschabell eschabell self-assigned this Oct 22, 2025
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally stylistic changes. This looks fairly ok otherwise.

@eschabell eschabell added the waiting-for-user Waiting for user/contributors feedback or requested changes label Nov 4, 2025
@eschabell
Copy link
Collaborator

@pwhelan we have some review suggestions for your attention.

pwhelan and others added 4 commits November 4, 2025 15:31
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>

The _mem_metrics_, or memory metrics plugin, generates metrics for memory statistics for processes using the `smaps_rollup` file for each process in /proc. This plugin works exclusively on Linux.

# Configuration parameters
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "# Configuration parameters"]

pwhelan and others added 4 commits November 4, 2025 15:32
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>

All metrics are logged as gauges since they can both increase and decrease. Supported gauges are:

- node_smaps_rollup_rss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

All metrics are logged as gauges since they can both increase and decrease. Supported gauges are:

- node_smaps_rollup_rss
- node_smaps_rollup_pss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]


- node_smaps_rollup_rss
- node_smaps_rollup_pss
- type=clean
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 4]

- node_smaps_rollup_rss
- node_smaps_rollup_pss
- type=clean
- type=dirty
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 4]

- node_smaps_rollup_pss
- type=clean
- type=dirty
- type=anon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 4]

- node_smaps_rollup_anon_huge_pages
- node_smaps_rollup_shmem_pmd_mapped
- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

- node_smaps_rollup_shmem_pmd_mapped
- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
- node_smaps_rollup_swap_pss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
- node_smaps_rollup_swap_pss
- node_smaps_rollup_locked
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

Comment on lines +88 to +89
- node_smaps_rollup_rss
- node_smaps_rollup_pss
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint-fix] reported by reviewdog 🐶

Suggested change
- node_smaps_rollup_rss
- node_smaps_rollup_pss
- node_smaps_rollup_rss
- node_smaps_rollup_pss
- type=clean
- type=dirty
- type=anon
- type=file
- type=shmem
- node_smaps_rollup_shared

Comment on lines +92 to +98
- type=anon
- type=file
- type=shmem
- node_smaps_rollup_shared
- type=clean
- type=dirty
- node_smaps_rollup_private
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint-fix] reported by reviewdog 🐶

Suggested change
- type=anon
- type=file
- type=shmem
- node_smaps_rollup_shared
- type=clean
- type=dirty
- node_smaps_rollup_private
- node_smaps_rollup_private

Comment on lines +101 to +111
- node_smaps_rollup_referenced
- node_smaps_rollup_anonymous
- node_smaps_rollup_lazy_free
- node_smaps_rollup_anon_huge_pages
- node_smaps_rollup_shmem_pmd_mapped
- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
- node_smaps_rollup_swap_pss
- node_smaps_rollup_locked
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint-fix] reported by reviewdog 🐶

Suggested change
- node_smaps_rollup_referenced
- node_smaps_rollup_anonymous
- node_smaps_rollup_lazy_free
- node_smaps_rollup_anon_huge_pages
- node_smaps_rollup_shmem_pmd_mapped
- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
- node_smaps_rollup_swap_pss
- node_smaps_rollup_locked
- node_smaps_rollup_referenced
- node_smaps_rollup_anonymous
- node_smaps_rollup_lazy_free
- node_smaps_rollup_anon_huge_pages
- node_smaps_rollup_shmem_pmd_mapped
- node_smaps_rollup_file_pmd_mapped
- node_smaps_rollup_shared_hugetlb
- node_smaps_rollup_private_hugetlb
- node_smaps_rollup_swap
- node_smaps_rollup_swap_pss
- node_smaps_rollup_locked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-code-merge waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants