Clarify parsing multiline messages (#10212) #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you sort the DCO as that's a hard requirement for merge? |
| | `java` | Process log entries generated by a Google Cloud Java language application and perform concatenation if multiline messages are detected. | | ||
| | Parser | Description | | ||
| |----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `docker` | Process a log entry generated by a Docker container engine. This This parser supports the concatenation of large log entries split by Docker. If you use this parser, and you also want to concatenate loglines like stacktraces, you can add the [multiline filter](../../pipeline/filters/multiline-stacktrace.md) to specify additional parsers | |
Contributor
There was a problem hiding this comment.
Think there's a typo here with This This
|
|
||
| - The usage of this filter depends on a previous configuration of a [multiline parser](../../administration/configuring-fluent-bit/multiline-parsing.md) definition. | ||
| - To concatenate messages read from a log file, it's highly recommended to use the multiline support in the [Tail plugin](https://docs.fluentbit.io/manual/pipeline/inputs/tail#multiline-support) itself. This is because performing concatenation while reading the log file is more performant. Concatenating messages originally split by Docker or CRI container engines, is supported in the [Tail plugin](https://docs.fluentbit.io/manual/pipeline/inputs/tail#multiline-support). | ||
| - To concatenate messages read from a log file, it's highly recommended to use the multiline support in the [Tail plugin](https://docs.fluentbit.io/manual/pipeline/inputs/tail#multiline-support) itself. This is because performing concatenation while reading the log file is more performant. Concatenating messages that were originally one line, but split by Docker or CRI container engines because of their size, is supported in the [Tail plugin](https://docs.fluentbit.io/manual/pipeline/inputs/tail#multiline-support) icw the `docker` or `cri` parser. to concatenate application logs like stacktraces on top of that, you can use this multiline filter. |
Contributor
There was a problem hiding this comment.
icw typo plus . after parser
Author
There was a problem hiding this comment.
fixed ("in combination with" + ". To"
esmerel
reviewed
Jul 16, 2025
Contributor
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
minor stylistic suggestions.
Comment on lines
22
to
23
| | Parser | Description | | ||
| |----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| |
Contributor
There was a problem hiding this comment.
Suggested change
| | Parser | Description | | |
| |----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |
| | Parser | Description | | |
| | ------ | ------------ | |
We don't need all that spacing, markdown draws the table fine without it and it's much easier to read.
Author
There was a problem hiding this comment.
sorry, my editor automatically changed it. Reverted.
| | `java` | Process log entries generated by a Google Cloud Java language application and perform concatenation if multiline messages are detected. | | ||
| | Parser | Description | | ||
| |----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `docker` | Process a log entry generated by a Docker container engine. This This parser supports the concatenation of large log entries split by Docker. If you use this parser, and you also want to concatenate loglines like stacktraces, you can add the [multiline filter](../../pipeline/filters/multiline-stacktrace.md) to specify additional parsers | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `docker` | Process a log entry generated by a Docker container engine. This This parser supports the concatenation of large log entries split by Docker. If you use this parser, and you also want to concatenate loglines like stacktraces, you can add the [multiline filter](../../pipeline/filters/multiline-stacktrace.md) to specify additional parsers | | |
| | `docker` | Process a log entry generated by a Docker container engine. This parser supports the concatenation of large log entries split by Docker. If you use this parser, and you also want to concatenate loglines like stacktraces, you can add the [multiline filter](../../pipeline/filters/multiline-stacktrace.md) to specify additional parsers. | |
| | Parser | Description | | ||
| |----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `docker` | Process a log entry generated by a Docker container engine. This This parser supports the concatenation of large log entries split by Docker. If you use this parser, and you also want to concatenate loglines like stacktraces, you can add the [multiline filter](../../pipeline/filters/multiline-stacktrace.md) to specify additional parsers | | ||
| | `cri` | Process a log entry generated by CRI-O container engine. Like the `docker` parser, it supports concatenation of log entries | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `cri` | Process a log entry generated by CRI-O container engine. Like the `docker` parser, it supports concatenation of log entries | | |
| | `cri` | Process a log entry generated by CRI-O container engine. Like the `docker` parser, it supports concatenation of log entries. | |
Comment on lines
26
to
28
| | `go` | Process log entries generated by a Go based language application and perform concatenation if multiline messages are detected. | | ||
| | `python` | Process log entries generated by a Python based language application and perform concatenation if multiline messages are detected. | | ||
| | `java` | Process log entries generated by a Google Cloud Java language application and perform concatenation if multiline messages are detected. | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `go` | Process log entries generated by a Go based language application and perform concatenation if multiline messages are detected. | | |
| | `python` | Process log entries generated by a Python based language application and perform concatenation if multiline messages are detected. | | |
| | `java` | Process log entries generated by a Google Cloud Java language application and perform concatenation if multiline messages are detected. | | |
| | `go` | Process log entries generated by a Go based language application and perform concatenation if multiline messages are detected. | | |
| | `python` | Process log entries generated by a Python based language application and perform concatenation if multiline messages are detected. | | |
| | `java` | Process log entries generated by a Google Cloud Java language application and perform concatenation if multiline messages are detected. | |
esmerel
reviewed
Jul 16, 2025
Contributor
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
minor stylistic suggestions.
make more clear the distinction between docker/cri splitting and merging, and multiline application log (stacktraces) merging Signed-off-by: Martin Fleurke <[email protected]>
esmerel
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make more clear the distinction between docker/cri splitting and merging, and multiline application log (stacktraces) merging