Skip to content

out_s3: Add a description for pure C parquet #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

out_s3: Add a description for pure C parquet #2111

wants to merge 5 commits into from

Conversation

@cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Oct 24, 2025

Corresponding of fluent/fluent-bit#10691.

@cosmo0920 cosmo0920 requested review from a team as code owners October 24, 2025 05:37
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-parquet-c-description-for-out_s3 branch from f167205 to 4390211 Compare October 24, 2025 05:41
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-parquet-c-description-for-out_s3 branch 2 times, most recently from b249070 to 6e4b47e Compare October 24, 2025 05:45
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-parquet-c-description-for-out_s3 branch from 6e4b47e to b659055 Compare October 24, 2025 05:46
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Oct 24, 2025 •
edited
Loading

@esmerel Good morning.
Vale warns some of usages that include Parquet is not following sentence style of capitalization. But Parquet is a proper noun. How do we handle on such warnings?

@eschabell eschabell self-assigned this Oct 27, 2025
@eschabell eschabell requested a review from esmerel October 27, 2025 20:44
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 27, 2025
@eschabell
Copy link
Collaborator

eschabell commented Oct 27, 2025

@esmerel review needed, see questions above.

esmerel added a commit that referenced this pull request Oct 27, 2025
@esmerel
Adding exception for Parquet per #2111
9e114e0 
Signed-off-by: Lynette Miles <[email protected]>
@esmerel esmerel mentioned this pull request Oct 27, 2025
Merged
@esmerel
Copy link
Contributor

esmerel commented Oct 27, 2025 •
edited
Loading

@esmerel Good morning. Vale warns some of usages that include Parquet is not following sentence style of capitalization. But Parquet is a proper noun. How do we handle on such warnings?

We add it to the spelling exceptions file for Vale. I went ahead and did that in #2116 =)

And also the heading file, which I should have realized. #2117

@esmerel esmerel mentioned this pull request Oct 27, 2025
Merged
esmerel
esmerel reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion that looks accidental

@cosmo0920 @esmerel
Apply suggestion from @esmerel
3b4b0d4 
Co-authored-by: Lynette  Miles <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-add-parquet-c-description-for-out_s3 branch from 0b5a2a3 to 3b4b0d4 Compare October 28, 2025 03:59
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
@esmerel
Adding exception for Parquet per fluent#2111
d174887 
Signed-off-by: Lynette Miles <[email protected]>
Signed-off-by: Tom <[email protected]>
patrick-stephens
patrick-stephens requested changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than adding the legacy format config as well.

pipeline/outputs/s3.md

Example configuration:

```yaml
Copy link
Contributor

@patrick-stephens patrick-stephens Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the legacy format as well

@patrick-stephens patrick-stephens added waiting-for-user Waiting for user/contributors feedback or requested changes and removed waiting-on-review Waiting on a review from mainteners labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esmerel esmerel esmerel left review comments

@patrick-stephens patrick-stephens patrick-stephens requested changes

Assignees

@eschabell eschabell

Labels

waiting-for-user Waiting for user/contributors feedback or requested changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cosmo0920 @eschabell @esmerel @patrick-stephens