filter_rewrite_tag: add and-combination for rules #349
Conversation
description for and-combination for rewrite_tag filter rules PR: fluent/fluent-bit#2399 Signed-off-by: Michael Voelker <[email protected]>
|
note: waiting for resolution on fluent/fluent-bit#2399 |
edsiper
added
the
waiting-for-user
|
@novegit can you please resolve the conflicts in this docs PR? |
Signed-off-by: Lynette Miles <[email protected]>
|
I corrected the conflict because it was due to format changes we made for consistency. |
Signed-off-by: Lynette Miles <[email protected]>
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
Correcting a couple more issues, including one i made.
Signed-off-by: Lynette Miles <[email protected]>
|
@eschabell The vale failure isn't spurious but it isn't related to this PR - I've corrected several things in this PR for stylistic issues so if it's technically correct then I'm ok with it. |
|
Why is it failing? Is it fixed elsewhere? |
Yep, the PR you approved a few minutes ago corrects most of the things. There may still be spelling, I didn't fix all of those. |
|
This doc PR is dependent on this code PR fluent/fluent-bit#2399 being merged, but it's still open @patrick-stephens so not sure if it's in there until code merge? |
eschabell
added
question
and removed
waiting-for-user
|
Ah yes, I must have missed that. Will need to revert and reopen this one |
* filter_rewrite_tag: add and-combination for rules description for and-combination for rewrite_tag filter rules PR: fluent/fluent-bit#2399 Signed-off-by: Michael Voelker <[email protected]> * Apply suggestions from code review Signed-off-by: Lynette Miles <[email protected]> * Apply suggestions from code review Signed-off-by: Lynette Miles <[email protected]> --------- Signed-off-by: Michael Voelker <[email protected]> Signed-off-by: Lynette Miles <[email protected]> Co-authored-by: Lynette Miles <[email protected]> Signed-off-by: Tom <[email protected]>
6 participants
description for and-combination of rewrite_tag filter rules
PR: fluent/fluent-bit#2399
Signed-off-by: Michael Voelker [email protected]