Basic type sanity checking on GetRecord to prevent panics on unexpected data

Adam Sussman · PettitWesley · commit d58ef6ba1d00 · 2020-07-28T20:42:36.000-07:00
Signed-off-by: Adam Sussman &lt;adam@olema.io&gt;
diff --git a/output/decoder.go b/output/decoder.go
@@ -77,6 +77,10 @@ func GetRecord(dec *FLBDecoder) (ret int, ts interface{}, rec map[interface{}]in
 	}
 
 	slice := reflect.ValueOf(m)
+	if slice.Kind() != reflect.Slice || slice.Len() != 2 {
+		return -1, 0, nil
+	}
+
 	t := slice.Index(0).Interface()
 	data := slice.Index(1)
 

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,10 @@ func GetRecord(dec *FLBDecoder) (ret int, ts interface{}, rec map[interface{}]in`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`slice := reflect.ValueOf(m)`
	`80`	`+ if slice.Kind() != reflect.Slice \|\| slice.Len() != 2 {`
	`81`	`+ return -1, 0, nil`
	`82`	`+ }`
	`83`	`+`
`80`	`84`	`t := slice.Index(0).Interface()`
`81`	`85`	`data := slice.Index(1)`
`82`	`86`