tests: internal: opentelemetry: adjust paths

Signed-off-by: Eduardo Silva <[email protected]>

Author: edsiper

tests/internal/CMakeLists.txt

@@ -171,7 +171,7 @@ set(UNIT_TESTS_DATA
   data/parser/regex.conf
   data/input_chunk/log/a_thousand_plus_one_bytes.log
   data/input_chunk/log/test_buffer_valid.log
-  data/opentelemetry/test_cases.json
+  data/opentelemetry/logs.json
   )
 
 set(FLB_TESTS_DATA_PATH ${CMAKE_CURRENT_SOURCE_DIR}/)

tests/internal/README.md

@@ -4,9 +4,12 @@ The following directory contains unit tests to validate specific functions of Fl
 
 ## OpenTelemetry Test Cases
 
-OpenTelemetry JSON tests are described in a single file located at
-`data/opentelemetry/test_cases.json`. Each entry is keyed by the test name and
-contains the following fields:
+OpenTelemetry JSON tests are described in two separate files:
+
+### Logs Test Cases (`data/opentelemetry/logs.json`)
+
+Logs test cases validate the `flb_opentelemetry_logs_json_to_msgpack()` function.
+Each entry is keyed by the test name and contains the following fields:
 
 ```
 {
@@ -28,6 +31,42 @@ contains the following fields:
 }
 ```
 
-When `expected_error` is present the unit test checks that
-`flb_opentelemetry_logs_json_to_msgpack()` fails with the given error code and
-message.
+### Traces Test Cases (`data/opentelemetry/traces.json`)
+
+Traces test cases validate the `flb_opentelemetry_json_traces_to_ctrace()` function.
+Each entry is keyed by the test name and contains the following fields:
+
+```
+{
+  "test_name": {
+    "input": { ... },          # OTLP/JSON traces payload
+    "expected": {               # successful result (optional)
+      # For successful cases, the test validates that a valid ctrace object is created
+    }
+  },
+  "error_case": {
+    "input": { ... },
+    "expected_error": {
+      "code": "FLB_OTEL_TRACES_ERR_*",
+      "message": "<error text>"
+    }
+  }
+}
+```
+
+### Error Handling
+
+When `expected_error` is present, the unit tests check that the respective functions fail with the given error code and message:
+
+- **Logs**: `flb_opentelemetry_logs_json_to_msgpack()` should fail with `FLB_OTEL_LOGS_ERR_*` codes
+- **Traces**: `flb_opentelemetry_json_traces_to_ctrace()` should fail with `FLB_OTEL_TRACES_ERR_*` codes
+
+### Test Coverage
+
+Both test files include comprehensive coverage for:
+
+- **Valid payloads**: Successful processing of well-formed OTLP JSON
+- **Invalid structure**: Missing required fields, wrong data types
+- **Hex decoding errors**: Invalid trace_id/span_id formats, zero-length strings, odd-length hex
+- **Field validation**: Required vs optional fields according to OpenTelemetry specification
+- **Edge cases**: Empty payloads, malformed JSON, boundary conditions

tests/internal/opentelemetry.c

@@ -408,6 +408,44 @@ void test_hex_to_id()
     TEST_CHECK(memcmp(out, expect, sizeof(expect)) == 0);
 }
 
+void test_hex_to_id_error_cases()
+{
+    unsigned char out[16];
+    int ret;
+
+    /* Test zero length string */
+    ret = flb_otel_utils_hex_to_id("", 0, out, 16);
+    TEST_CHECK(ret == 0); /* Zero length should succeed (empty output) */
+
+    /* Test odd length string */
+    ret = flb_otel_utils_hex_to_id("123", 3, out, 16);
+    TEST_CHECK(ret == -1); /* Odd length should fail */
+
+    /* Test invalid hex character */
+    ret = flb_otel_utils_hex_to_id("0000000000000000000000000000000G", 32, out, 16);
+    TEST_CHECK(ret == -1); /* Invalid hex character should fail */
+
+    /* Test mixed valid/invalid hex */
+    ret = flb_otel_utils_hex_to_id("0000000000000000000000000000000Z", 32, out, 16);
+    TEST_CHECK(ret == -1); /* Invalid hex character should fail */
+
+    /* Test valid hex with wrong output size */
+    ret = flb_otel_utils_hex_to_id("00000000000000000000000000000001", 32, out, 8);
+    TEST_CHECK(ret == 0); /* Should succeed even with larger output buffer */
+
+    /* Test valid hex with correct size */
+    ret = flb_otel_utils_hex_to_id("0000000000000001", 16, out, 8);
+    TEST_CHECK(ret == 0); /* Should succeed */
+
+    /* Test valid hex with uppercase */
+    ret = flb_otel_utils_hex_to_id("0000000000000000000000000000000A", 32, out, 16);
+    TEST_CHECK(ret == 0); /* Should succeed with uppercase hex */
+
+    /* Test valid hex with lowercase */
+    ret = flb_otel_utils_hex_to_id("0000000000000000000000000000000a", 32, out, 16);
+    TEST_CHECK(ret == 0); /* Should succeed with lowercase hex */
+}
+
 void test_convert_string_number_to_u64()
 {
     uint64_t val;
@@ -499,7 +537,7 @@ void test_json_payload_get_wrapped_value()
     msgpack_unpacked_destroy(&up);
 }
 
-#define OTEL_TEST_CASES_PATH      FLB_TESTS_DATA_PATH "/data/opentelemetry/test_cases.json"
+#define OTEL_TEST_CASES_PATH      FLB_TESTS_DATA_PATH "/data/opentelemetry/logs.json"
 #define OTEL_TRACES_TEST_CASES_PATH FLB_TESTS_DATA_PATH "/data/opentelemetry/traces.json"
 
 void test_opentelemetry_cases()
@@ -904,7 +942,6 @@ void test_trace_span_binary_sizes()
     struct flb_record_accessor *ra_span_id;
     struct flb_ra_value *val_trace_id;
     struct flb_ra_value *val_span_id;
-    size_t len;
 
     /* Test input with trace_id and span_id */
     input_json = "{\"resourceLogs\":[{\"scopeLogs\":[{\"logRecords\":[{\"timeUnixNano\":\"1640995200000000000\",\"traceId\":\"5B8EFFF798038103D269B633813FC60C\",\"spanId\":\"EEE19B7EC3C1B174\",\"body\":{\"stringValue\":\"test\"}}]}]}]}";
@@ -979,6 +1016,7 @@ void test_trace_span_binary_sizes()
 /* Test list */
 TEST_LIST = {
     { "hex_to_id", test_hex_to_id },
+    { "hex_to_id_error_cases", test_hex_to_id_error_cases },
     { "convert_string_number_to_u64", test_convert_string_number_to_u64 },
     { "find_map_entry_by_key", test_find_map_entry_by_key },
     { "json_payload_get_wrapped_value", test_json_payload_get_wrapped_value },