filter-modify: Additional commentary

nigels-com · nigels-com · commit 0b2fa3debc7f · 2019-10-20T20:45:46.000+10:00
Signed-off-by: Nigel Stewart &lt;nigels@nigels.com&gt;
diff --git a/plugins/filter_modify/modify.c b/plugins/filter_modify/modify.c
@@ -1181,6 +1181,8 @@ static inline int apply_rule_UTF8(msgpack_packer * packer,
         msgpack_pack_map(packer, map->via.map.size);
         for (i = 0; i < map->via.map.size; i++) {
             msgpack_pack_object(packer, map->via.map.ptr[i].key);
+
+            /* Do UTF8 encoding for this value? */
             if (map->via.map.ptr[i].val.type == MSGPACK_OBJECT_STR &&
                 kv_key_matches_str_rule_key(&map->via.map.ptr[i], rule)) {
                 size_t size = 0;
@@ -1216,7 +1218,6 @@ static inline int apply_rule_UTF8(msgpack_packer * packer,
                         free(buffer);
                     }
                 }
-
             }
             msgpack_pack_object(packer, map->via.map.ptr[i].val);
         }

Original file line number	Diff line number	Diff line change
`@@ -1181,6 +1181,8 @@ static inline int apply_rule_UTF8(msgpack_packer * packer,`
`1181`	`1181`	`msgpack_pack_map(packer, map->via.map.size);`
`1182`	`1182`	`for (i = 0; i < map->via.map.size; i++) {`
`1183`	`1183`	`msgpack_pack_object(packer, map->via.map.ptr[i].key);`
	`1184`	`+`
	`1185`	`+ /* Do UTF8 encoding for this value? */`
`1184`	`1186`	`if (map->via.map.ptr[i].val.type == MSGPACK_OBJECT_STR &&`
`1185`	`1187`	`kv_key_matches_str_rule_key(&map->via.map.ptr[i], rule)) {`
`1186`	`1188`	`size_t size = 0;`
`@@ -1216,7 +1218,6 @@ static inline int apply_rule_UTF8(msgpack_packer * packer,`
`1216`	`1218`	`free(buffer);`
`1217`	`1219`	`}`
`1218`	`1220`	`}`
`1219`		`-`
`1220`	`1221`	`}`
`1221`	`1222`	`msgpack_pack_object(packer, map->via.map.ptr[i].val);`
`1222`	`1223`	`}`