workflows: add sanity check on release (#7474)

* workflows: add sanity check on release

Signed-off-by: Patrick Stephens <[email protected]>

* workflows: remove unnecessary change

Signed-off-by: Patrick Stephens <[email protected]>

---------

Signed-off-by: Patrick Stephens <[email protected]>

Author: Pat

.github/workflows/staging-release.yaml

@@ -31,12 +31,11 @@ jobs:
 
   staging-release-version-check:
     name: Check staging release matches
-    environment: release
     runs-on: ubuntu-latest
     outputs:
       major-version: ${{ steps.get_major_version.outputs.value }}
     permissions:
-      contents: none
+      contents: read
     steps:
     - name: Get the version on staging
       run: |
@@ -64,6 +63,17 @@ jobs:
       env:
         RELEASE_VERSION: ${{ github.event.inputs.version }}
 
+    - name: Checkout repository
+      uses: actions/checkout@v3
+  
+    # Check we can download the AppVeyor build which confirms it matches the version to release as well as being a successful build
+    - name: Get Appveyor binaries
+      run: |
+        ./packaging/appveyor-download.sh
+      shell: bash
+      env:
+        TAG: v${{ github.event.inputs.version }}
+
   staging-release-generate-package-matrix:
     name: Get package matrix
     runs-on: ubuntu-latest