Skip to content

Commit 3b44afa

Browse files
DavidKorczynskiedsiper
authored andcommitted
aws: fix some possible leaks
Signed-off-by: David Korczynski <[email protected]>
1 parent 514b40f commit 3b44afa

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

src/aws/flb_aws_credentials_http.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,10 @@ struct flb_aws_credentials *flb_parse_json_credentials(char *response,
473473
t = &tokens[i];
474474
current_token = &response[t->start];
475475
len = t->end - t->start;
476+
if (creds->access_key_id != NULL) {
477+
flb_error("Triyng to double allocate access_key_id");
478+
goto error;
479+
}
476480
creds->access_key_id = flb_sds_create_len(current_token, len);
477481
if (!creds->access_key_id) {
478482
flb_errno();
@@ -486,6 +490,10 @@ struct flb_aws_credentials *flb_parse_json_credentials(char *response,
486490
t = &tokens[i];
487491
current_token = &response[t->start];
488492
len = t->end - t->start;
493+
if (creds->secret_access_key != NULL) {
494+
flb_error("Triyng to double allocate secret_access_key");
495+
goto error;
496+
}
489497
creds->secret_access_key = flb_sds_create_len(current_token,
490498
len);
491499
if (!creds->secret_access_key) {
@@ -499,6 +507,10 @@ struct flb_aws_credentials *flb_parse_json_credentials(char *response,
499507
t = &tokens[i];
500508
current_token = &response[t->start];
501509
len = t->end - t->start;
510+
if (creds->session_token != NULL) {
511+
flb_error("Triyng to double allocate session_token");
512+
goto error;
513+
}
502514
creds->session_token = flb_sds_create_len(current_token, len);
503515
if (!creds->session_token) {
504516
flb_errno();

0 commit comments

Comments
 (0)