Skip to content

Commit 40a5ffa

Browse files
committed
filter_log_to_metrics: Plug a leak on exception
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
1 parent b9f17cb commit 40a5ffa

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

plugins/filter_log_to_metrics/log_to_metrics.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,7 @@ static int cb_log_to_metrics_init(struct flb_filter_instance *f_ins,
614614
struct flb_sched *sched;
615615
const char *emitter_alias = NULL;
616616
flb_sds_t emitter_alias_tmp = NULL;
617+
flb_sds_t tmp = NULL;
617618
const char *fname;
618619

619620
/* Create context */
@@ -813,12 +814,15 @@ static int cb_log_to_metrics_init(struct flb_filter_instance *f_ins,
813814
log_to_metrics_destroy(ctx);
814815
return -1;
815816
}
816-
emitter_alias_tmp = flb_sds_printf(&emitter_alias_tmp, "emitter_for_%s", fname);
817-
if (!emitter_alias_tmp) {
817+
tmp = flb_sds_printf(&emitter_alias_tmp, "emitter_for_%s", fname);
818+
if (!tmp) {
819+
flb_sds_destroy(emitter_alias_tmp);
820+
emitter_alias_tmp = NULL;
818821
flb_errno();
819822
log_to_metrics_destroy(ctx);
820823
return -1;
821824
}
825+
emitter_alias_tmp = tmp;
822826
emitter_alias = emitter_alias_tmp;
823827
}
824828

0 commit comments

Comments
 (0)