in_calyptia_fleet: fix double free when calyptia API returns with an empty response payload.

pwhelan · edsiper · commit 5a9a4e8be1d6 · 2023-12-21T16:20:09.000-06:00
Signed-off-by: Phillip Whelan &lt;phil@calyptia.com&gt;
diff --git a/plugins/in_calyptia_fleet/in_calyptia_fleet.c b/plugins/in_calyptia_fleet/in_calyptia_fleet.c
@@ -917,7 +917,6 @@ static struct flb_http_client *fleet_http_do(struct flb_in_calyptia_fleet_config
 
     if (client->resp.payload_size <= 0) {
         flb_plg_error(ctx->ins, "empty response");
-        flb_http_client_destroy(client);
         goto http_do_error;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -917,7 +917,6 @@ static struct flb_http_client *fleet_http_do(struct flb_in_calyptia_fleet_config`
`917`	`917`
`918`	`918`	`if (client->resp.payload_size <= 0) {`
`919`	`919`	`flb_plg_error(ctx->ins, "empty response");`
`920`		`- flb_http_client_destroy(client);`
`921`	`920`	`goto http_do_error;`
`922`	`921`	`}`
`923`	`922`