Skip to content

Commit 640d668

Browse files
committed
Use pre-created ctx->value_ra
Incorporate changes that were introduced with e6bc684
1 parent 5c28512 commit 640d668

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

plugins/filter_log_to_metrics/log_to_metrics.c

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -922,13 +922,7 @@ static int cb_log_to_metrics_filter(const void *data, size_t bytes,
922922
break;
923923
}
924924
// If value_field is set, increment counter by value
925-
ra = flb_ra_create(ctx->value_field, FLB_TRUE);
926-
if (!ra) {
927-
flb_plg_error(ctx->ins, "invalid record accessor key, aborting");
928-
break;
929-
}
930-
931-
rval = flb_ra_get_value_object(ra, map);
925+
rval = flb_ra_get_value_object(ctx->value_ra, map);
932926

933927
if (!rval) {
934928
flb_warn("given value field is empty or not existent");
@@ -946,18 +940,13 @@ static int cb_log_to_metrics_filter(const void *data, size_t bytes,
946940
else {
947941
flb_plg_error(f_ins,
948942
"cannot convert given value to metric");
943+
flb_ra_key_value_destroy(rval);
949944
break;
950945
}
951946
ret = cmt_counter_add(ctx->c, ts, counter_value,
952947
label_count, label_values);
953-
if (rval) {
954-
flb_ra_key_value_destroy(rval);
955-
rval = NULL;
956-
}
957-
if (ra) {
958-
flb_ra_destroy(ra);
959-
ra = NULL;
960-
}
948+
flb_ra_key_value_destroy(rval);
949+
rval = NULL;
961950
break;
962951

963952
case FLB_LOG_TO_METRICS_GAUGE:

0 commit comments

Comments
 (0)