in_podman_metrics: Plug a resource leak on exception (CID 507805)

cosmo0920 · edsiper · commit 667e50e302b7 · 2024-08-29T14:16:17.000-06:00
Signed-off-by: Hiroshi Hatake &lt;hiroshi@chronosphere.io&gt;
diff --git a/plugins/in_podman_metrics/podman_metrics_data.c b/plugins/in_podman_metrics/podman_metrics_data.c
@@ -287,6 +287,7 @@ int collect_sysfs_directories(struct flb_in_metrics *ctx, flb_sds_t name)
                 pth = flb_malloc(sizeof(struct sysfs_path));
                 if (!pth) {
                     flb_errno();
+                    closedir(dir);
                     return -1;
                 }
                 pth->path = flb_sds_create(path);

Original file line number	Diff line number	Diff line change
`@@ -287,6 +287,7 @@ int collect_sysfs_directories(struct flb_in_metrics *ctx, flb_sds_t name)`
`287`	`287`	`pth = flb_malloc(sizeof(struct sysfs_path));`
`288`	`288`	`if (!pth) {`
`289`	`289`	`flb_errno();`
	`290`	`+ closedir(dir);`
`290`	`291`	`return -1;`
`291`	`292`	`}`
`292`	`293`	`pth->path = flb_sds_create(path);`