Update plugins/out_es/es.c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Todd Kennedy <[email protected]>

Author: tkennedy1-godaddy

plugins/out_es/es.c

@@ -890,28 +890,21 @@ static void cb_es_flush(struct flb_event_chunk *event_chunk,
         flb_http_basic_auth(c, ctx->cloud_user, ctx->cloud_passwd);
     }
     else if (ctx->http_api_key) {
-        header_buffer = flb_sds_create_size(strlen(ctx->http_api_key) + 64);
-
-        if (header_buffer == NULL) {
-            flb_error("[out_es] failed to create header buffer");
+        header_line = flb_sds_printf(NULL, "ApiKey %s", ctx->http_api_key);
+        if (header_line == NULL) {
+            flb_plg_error(ctx->ins, "failed to format API key auth header");
+            goto retry;
         }
-        else {
-            header_line = flb_sds_printf(&header_buffer, "ApiKey %s", ctx->http_api_key);
-
-            if (header_line != NULL) {
-                flb_http_add_header(c,
-                                    FLB_HTTP_HEADER_AUTH,
-                                strlen(FLB_HTTP_HEADER_AUTH),
-                                    header_line,
-                                flb_sds_len(header_line));
-            }
-            else {
-                flb_sds_destroy(header_buffer);
-                goto error;
-            }
 
-            flb_sds_destroy(header_buffer);
+        if (flb_http_add_header(c,
+                                FLB_HTTP_HEADER_AUTH, strlen(FLB_HTTP_HEADER_AUTH),
+                                header_line, flb_sds_len(header_line)) != 0) {
+            flb_plg_error(ctx->ins, "failed to add API key auth header");
+            flb_sds_destroy(header_line);
+            goto retry;
         }
+
+        flb_sds_destroy(header_line);
     }
 
 #ifdef FLB_HAVE_AWS