Skip to content

Commit 74e1586

Browse files
authored
ra: fix undefined behavior on error (#2452)
flb_ra_parser_destroy(rp) may attempt to free uninitialized key->subkeys when key->name failed to allocate. Signed-off-by: Zero King <[email protected]>
1 parent dd18cea commit 74e1586

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/record_accessor/flb_ra_parser.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,12 +224,12 @@ struct flb_ra_parser *flb_ra_parser_string_create(char *str, int len)
224224
flb_ra_parser_destroy(rp);
225225
return NULL;
226226
}
227+
rp->key->subkeys = NULL;
227228
rp->key->name = flb_sds_create_len(str, len);
228229
if (!rp->key->name) {
229230
flb_ra_parser_destroy(rp);
230231
return NULL;
231232
}
232-
rp->key->subkeys = NULL;
233233

234234
return rp;
235235
}

0 commit comments

Comments
 (0)