Skip to content

Commit 7ac03a2

Browse files
committed
Apply code quality changes
Signed-off-by: Ryan Underwood <[email protected]>
1 parent 3863eea commit 7ac03a2

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

include/fluent-bit/flb_aws_util.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ struct flb_aws_client {
104104
int debug_only;
105105

106106
/* Callbacks context */
107-
struct flb_callback *callback;
107+
struct flb_callback *http_cb_ctx;
108108
};
109109

110110
/* frees dynamic_headers */

src/aws/flb_aws_util.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,10 @@ struct flb_aws_client *flb_aws_client_create()
268268
client->client_vtable = &client_vtable;
269269
client->retry_requests = FLB_FALSE;
270270
client->debug_only = FLB_FALSE;
271-
client->callback = flb_callback_create("aws client"); // FIXME: what name?
272-
if (!client->callback) {
271+
client->http_cb_ctx = flb_callback_create("aws client"); // FIXME: what name?
272+
if (!client->http_cb_ctx) {
273273
flb_errno();
274+
flb_callback_destroy(client->http_cb_ctx);
274275
return NULL;
275276
}
276277
return client;
@@ -296,7 +297,7 @@ void flb_aws_client_destroy(struct flb_aws_client *aws_client)
296297
if (aws_client->extra_user_agent) {
297298
flb_sds_destroy(aws_client->extra_user_agent);
298299
}
299-
flb_free(aws_client->callback);
300+
flb_callback_destroy(aws_client->http_cb_ctx);
300301
flb_free(aws_client);
301302
}
302303
}
@@ -392,7 +393,7 @@ struct flb_http_client *request_do(struct flb_aws_client *aws_client,
392393
goto error;
393394
}
394395

395-
c->cb_ctx = aws_client->callback;
396+
c->cb_ctx = aws_client->http_cb_ctx;
396397

397398
/* Increase the maximum HTTP response buffer size to fit large responses from AWS services */
398399
ret = flb_http_buffer_size(c, FLB_MAX_AWS_RESP_BUFFER_SIZE);

0 commit comments

Comments
 (0)