workflows: fix release test job (#5586)

* packaging: remove tty needs

Signed-off-by: Patrick Stephens <[email protected]>

* workflows: update comments

Signed-off-by: Patrick Stephens <[email protected]>

Author: Pat

.github/workflows/staging-release.yaml

@@ -298,6 +298,8 @@ jobs:
           COSIGN_EXPERIMENTAL: "true"
 
   # This will require a sign off so can be done after packages are updated to confirm
+  # Until S3 bucket is set up as release will only test what is in the server from a prior release.
+  # TODO: https://github.com/fluent/fluent-bit/issues/5098
   staging-release-smoke-test:
     name: Run smoke tests on release artefacts
     permissions:

packaging/test-release-packages.sh

@@ -23,7 +23,7 @@ YUM_TARGETS=("centos:7"
 for IMAGE in "${APT_TARGETS[@]}"
 do
     echo "Testing $IMAGE"
-    $CONTAINER_RUNTIME run --rm -it \
+    $CONTAINER_RUNTIME run --rm -t \
         -e FLUENT_BIT_PACKAGES_URL="${FLUENT_BIT_PACKAGES_URL:-https://packages.fluentbit.io}" \
         -e FLUENT_BIT_PACKAGES_KEY="${FLUENT_BIT_PACKAGES_KEY:-https://packages.fluentbit.io/fluentbit.key}" \
         "$IMAGE" \
@@ -33,7 +33,7 @@ done
 for IMAGE in "${YUM_TARGETS[@]}"
 do
     echo "Testing $IMAGE"
-    $CONTAINER_RUNTIME run --rm -it \
+    $CONTAINER_RUNTIME run --rm -t \
         -e FLUENT_BIT_PACKAGES_URL="${FLUENT_BIT_PACKAGES_URL:-https://packages.fluentbit.io}" \
         -e FLUENT_BIT_PACKAGES_KEY="${FLUENT_BIT_PACKAGES_KEY:-https://packages.fluentbit.io/fluentbit.key}" \
         "$IMAGE" \