fixup! http_server/health: Implement throughput health check

Address Leonardo review: Refactor to not use goto

Signed-off-by: Thiago Padilha <[email protected]>

Author: tchrono

src/http_server/api/v1/health.c

@@ -332,30 +332,31 @@ static int check_throughput_health(uint64_t in_records,
                                          _head);
     }
 
-    if (last_sample &&
-        in_records == last_sample->in_records &&
-        out_records == last_sample->out_records) {
-        flb_debug("[api/v1/health/throughput]: no changes since last check");
-        /* don't collect another sample unless either in_records or out_records have
-         * changed*/
-        goto check;
-    }
+    if (!last_sample ||
+         in_records != last_sample->in_records ||
+         out_records != last_sample->out_records) {
+
+        sample = flb_malloc(sizeof(struct flb_hs_throughput_sample));
+
+        if (sample) {
+            sample->timestamp_seconds = timestamp_seconds;
+            sample->in_records = in_records;
+            sample->out_records = out_records;
+            mk_list_add(&sample->_head, sample_list);
+        } else {
+            flb_error("[api/v1/health/throughput]: failed to allocate sample");
+        }
 
-    sample = flb_malloc(sizeof(struct flb_hs_throughput_sample));
-    if (!sample) {
-        flb_error("[api/v1/health/throughput]: failed to allocate sample");
-        goto check;
+    } else {
+        /* don't collect another sample unless either in_records or out_records have
+         * changed since last check */
+        flb_debug("[api/v1/health/throughput]: no changes since last check");
     }
 
-    sample->timestamp_seconds = timestamp_seconds;
-    sample->in_records = in_records;
-    sample->out_records = out_records;
-    mk_list_add(&sample->_head, sample_list);
-
-check:
     flb_debug("[api/v1/health/throughput]: check samples start %d %f",
               sample_count,
               out_in_ratio_threshold);
+
     healthy = false;
     mk_list_foreach_safe_r(head, tmp, sample_list) {
         entry = mk_list_entry(head, struct flb_hs_throughput_sample, _head);
@@ -379,6 +380,7 @@ static int check_throughput_health(uint64_t in_records,
                   out_in_ratio,
                   out_rate,
                   in_rate);
+
         if (healthy) {
             break;
         }
@@ -399,6 +401,7 @@ static int check_throughput_health(uint64_t in_records,
     rv = count < sample_count || healthy;
     flb_debug("checking throughput samples stop, result: %s",
               rv ? "healthy" :"unhealthy");
+
     return rv;
 }