tests: internal: opentelemetry: add unit test for issue #10648

Signed-off-by: Eduardo Silva <[email protected]>

Author: edsiper

tests/internal/data/opentelemetry/test_cases.json

@@ -86,12 +86,12 @@
     }
   },
 
-  "scope_kvlist_error": {
+  "scope_kvlist_empty_value": {
     "input": {
       "resourceLogs": [{
         "scopeLogs": [{
           "scope": {
-            "attributes": [{"key": "only-key"}]
+            "attributes": [{"key": "empty-key"}]
           },
           "logRecords": [{
             "timeUnixNano": "1",
@@ -100,8 +100,33 @@
         }]
       }]
     },
-    "expected_error": {
-      "code": "FLB_OTEL_LOGS_ERR_SCOPE_KVLIST"
+    "expected": {
+      "group_metadata": {"schema":"otlp","resource_id":0,"scope_id":0},
+      "group_body": {"resource":{}, "scope":{"attributes":{"empty-key":""}}},
+      "log_metadata": {"otlp":{}},
+      "log_body": {"log": "test"}
+    }
+  },
+
+  "scope_kvlist_wrong_value_type": {
+    "input": {
+      "resourceLogs": [{
+        "scopeLogs": [{
+          "scope": {
+            "attributes": [{"key": "empty-key"}]
+          },
+          "logRecords": [{
+            "timeUnixNano": "1",
+            "body": {"stringValue": "test"}
+          }]
+        }]
+      }]
+    },
+    "expected": {
+      "group_metadata": {"schema":"otlp","resource_id":0,"scope_id":0},
+      "group_body": {"resource":{}, "scope":{"attributes":{"empty-key":""}}},
+      "log_metadata": {"otlp":{}},
+      "log_body": {"log": "test"}
     }
   },
 
@@ -926,7 +951,7 @@
             "scope": {
               "name": "invalid-scope",
               "attributes": [
-                {"key": "incomplete-kv-pair"}
+                {"key": "incomplete-kv-pair", "value": "wrong value"}
               ]
             },
             "logRecords": [
@@ -1174,6 +1199,31 @@
     "expected_error": {
       "code": "FLB_OTEL_LOGS_ERR_UNEXPECTED_LOGRECORDS_TYPE"
     }
-  }
+  },
 
+  "issue_10648_string_with_null_value": {
+    "input": {
+      "resourceLogs": [{
+        "scopeLogs": [{
+          "logRecords": [{
+            "timeUnixNano": "1722904465173450100",
+            "body": {
+              "kvlistValue": {
+                "values": [
+                  {"key": "test_key", "value": {"stringValue": null}},
+                  {"key": "normal_key", "value": {"stringValue": "normal_value"}}
+                ]
+              }
+            }
+          }]
+        }]
+      }]
+    },
+    "expected": {
+      "group_metadata": {"schema":"otlp","resource_id":0,"scope_id":0},
+      "group_body": {"resource":{}},
+      "log_metadata": {"otlp":{}},
+      "log_body": {"test_key": "", "normal_key": "normal_value"}
+    }
+  }
 }

tests/internal/opentelemetry.c

@@ -628,12 +628,24 @@ void test_opentelemetry_cases()
                     /* Fall back to legacy format validation */
                     meta_json = get_group_metadata(enc.output_buffer, enc.output_length);
                     TEST_CHECK(strcmp(meta_json, expect_group_meta) == 0);
+                    if (strcmp(meta_json, expect_group_meta) != 0) {
+                        TEST_MSG("group metadata mismatch: expected '%s', got '%s'",
+                                 expect_group_meta, meta_json);
+                    }
 
                     body_json = get_group_body(enc.output_buffer, enc.output_length);
                     TEST_CHECK(strcmp(body_json, expect_group_body) == 0);
+                    if (strcmp(body_json, expect_group_body) != 0) {
+                        TEST_MSG("group body mismatch: expected '%s', got '%s'",
+                                 expect_group_body, body_json);
+                    }
 
                     log_json = get_log_body(enc.output_buffer, enc.output_length);
                     TEST_CHECK(strcmp(log_json, expect_log_body) == 0);
+                    if (strcmp(log_json, expect_log_body) != 0) {
+                        TEST_MSG("log body mismatch: expected '%s', got '%s'",
+                                 expect_log_body, log_json);
+                    }
                 }
                 else {
                     TEST_CHECK_(0, "extended format validation failed: %s", case_name);
@@ -693,6 +705,7 @@ void test_opentelemetry_cases()
                         exp_code, error_status,
                         flb_opentelemetry_error_to_string(error_status));
             if (error_status != exp_code) {
+
                 flb_log_event_encoder_destroy(&enc);
                 flb_free(input_json);
                 flb_free(case_name);