out_azure_kusto: addressed review comments

Signed-off-by: Tanmaya Panda <[email protected]>

Author: tanmaya-panda1

plugins/out_azure_blob/azure_blob.c

@@ -473,6 +473,7 @@ static int send_blob(struct flb_config *config,
     /* Allocate memory for the random string dynamically */
     generated_random_string = flb_malloc(ctx->blob_uri_length + 1);
     if (!generated_random_string) {
+        flb_errno();
         flb_plg_error(ctx->ins, "cannot allocate memory for random string");
         flb_sds_destroy(ref_name);
         return FLB_RETRY;
@@ -1201,7 +1202,6 @@ static void cb_azure_blob_ingest(struct flb_config *config, void *data) {
 
     /* Log entry point and container information */
     flb_plg_debug(ctx->ins, "Running upload timer callback (cb_azure_blob_ingest)..");
-    flb_plg_debug(ctx->ins, "inside ctx : container name is %s", ctx->container_name);
 
     /* Initialize jitter for retry mechanism */
     srand(time(NULL));

plugins/out_azure_blob/azure_blob_store.c

@@ -122,7 +122,6 @@ int azure_blob_store_buffer_put(struct flb_azure_blob *ctx, struct azure_blob_fi
     flb_sds_t name;
     struct flb_fstore_file *fsf;
     size_t space_remaining;
-    // flb_sds_t path_sds;
 
     if (ctx->store_dir_limit_size > 0 && ctx->current_buffer_size + bytes >= ctx->store_dir_limit_size) {
         flb_plg_error(ctx->ins, "Buffer is full: current_buffer_size=%zu, new_data=%zu, store_dir_limit_size=%zu bytes",
@@ -154,6 +153,7 @@ int azure_blob_store_buffer_put(struct flb_azure_blob *ctx, struct azure_blob_fi
         if (ret == -1) {
             flb_plg_warn(ctx->ins, "Deleting buffer file because metadata could not be written");
             flb_fstore_file_delete(ctx->fs, fsf);
+            flb_sds_destroy(name);
             return -1;
         }
 
@@ -163,6 +163,7 @@ int azure_blob_store_buffer_put(struct flb_azure_blob *ctx, struct azure_blob_fi
             flb_errno();
             flb_plg_warn(ctx->ins, "Deleting buffer file because azure_blob context creation failed");
             flb_fstore_file_delete(ctx->fs, fsf);
+            flb_sds_destroy(name);
             return -1;
         }
         azure_blob_file->fsf = fsf;
@@ -334,7 +335,6 @@ int azure_blob_store_exit(struct flb_azure_blob *ctx)
             fsf = mk_list_entry(f_head, struct flb_fstore_file, _head);
             if (fsf->data != NULL) {
                 azure_blob_file = fsf->data;
-                //flb_sds_destroy(azure_blob_file->file_path);
                 flb_free(azure_blob_file);
             }
         }
@@ -400,25 +400,6 @@ int azure_blob_store_file_inactive(struct flb_azure_blob *ctx, struct azure_blob
     return ret;
 }
 
-void azure_blob_file_cleanup(struct azure_blob_file *file)
-{
-    if (file == NULL) {
-        return;
-    }
-
-    // Free the file path if it was dynamically allocated
-    /*if (file->file_path != NULL) {
-        flb_sds_destroy(file->file_path);
-        file->file_path = NULL;
-    }*/
-
-    // If there are other dynamically allocated members, free them here
-    // For now, we only free file_path as per the given struct
-
-    // Free the azure_blob_file itself
-    //flb_free(file);
-}
-
 int azure_blob_store_file_cleanup(struct flb_azure_blob *ctx, struct azure_blob_file *azure_blob_file)
 {
     struct flb_fstore_file *fsf;