cprofiles: can't compile due to incompatible-pointer-types

[ThomasDevoogdt]

Bug Report

/home/thomas/br-test-pkg/bootlin-armv7-glibc/build/fluent-bit-3.2.0/lib/cprofiles/src/cprof_profile.c: In function ‘cprof_profile_destroy’:
/home/thomas/br-test-pkg/bootlin-armv7-glibc/build/fluent-bit-3.2.0/lib/cprofiles/src/cprof_profile.c:160:18: error: assignment to ‘struct cprof_mapping *’ from incompatible pointer type ‘struct cprof_location *’ [-Wincompatible-pointer-types]
  160 |         location = cfl_list_entry(iterator,
      |                  ^
/home/thomas/br-test-pkg/bootlin-armv7-glibc/build/fluent-bit-3.2.0/lib/cprofiles/src/cprof_profile.c:166:32: error: passing argument 1 of ‘cprof_location_destroy’ from incompatible pointer type [-Wincompatible-pointer-types]
  166 |         cprof_location_destroy(location);
      |                                ^~~~~~~~
      |                                |
      |                                struct cprof_mapping *
In file included from /home/thomas/br-test-pkg/bootlin-armv7-glibc/build/fluent-bit-3.2.0/lib/cprofiles/src/cprof_profile.c:21:
/home/thomas/br-test-pkg/bootlin-armv7-glibc/build/fluent-bit-3.2.0/lib/cprofiles/include/cprofiles/cprofiles.h:304:52: note: expected ‘struct cprof_location *’ but argument is of type ‘struct cprof_mapping *’
  304 | void cprof_location_destroy(struct cprof_location *instance);
      |                             ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

Describe the bug

New toolchains are asserting on it.

To Reproduce

• Rubular link if applicable:
• Example log message if applicable:

{"log":"YOUR LOG MESSAGE HERE","stream":"stdout","time":"2018-06-11T14:37:30.681701731Z"}

• Steps to reproduce the problem:

Expected behavior

Screenshots

Your Environment

• Version used: 3.2.0
• Configuration: Buildroot
• Environment name and version (e.g. Kubernetes? What version?):
• Server type and version:
• Operating System and version:
• Filters and plugins:

Additional context

@leonardo-albertovich can you have a look, since you've added this in 2954908?

[edsiper]

@ThomasDevoogdt thanks for this report. I have fixed the data type problem, however note that cprofiles still needs other adjustments regarding dependencies (profiles are under active development).

[ThomasDevoogdt]

@ThomasDevoogdt thanks for this report. I have fixed the data type problem, however note that cprofiles still needs other adjustments regarding dependencies (profiles are under active development).

Hi @edsiper, I guess you didn't saw my PR fluent/cprofiles#3, can you have a look, since that one also solves another related issue.

BTW, since it's under active development, why is it already part of the v3.2.0 stable release?

[jeredfloyd]

I submitted PR #9598 to resolve this a few hours after release, but haven't seen motion. Does the project not accept outside PRs?

[edsiper]

@ThomasDevoogdt Didn't see your PR. Note that profiles are not stable in OTel, the feature needs to be enabled manually since it's in experimental mode.

@jeredfloyd for dependencies or external libraries that lives in lib/, the PR needs to be send to the original repository from where we pull that library, in this case is fluent/cprofiles.

[ThomasDevoogdt]

@edsiper But why is that experimental issue enabled then? See https://github.com/fluent/fluent-bit/blob/master/CMakeLists.txt#L158-L159. Btw, there is a small typo in the comment line there.

[edsiper]

@ThomasDevoogdt Because OpenTelemetry Profiles schema is not stable, it's still flagged as in development mode and they are still adapting it which causes breaking changes:

https://github.com/open-telemetry/opentelemetry-proto/tree/main/opentelemetry/proto/profiles/v1development

[ThomasDevoogdt]

@edsiper I understand, but the issue here is that something which is not yet stable, is enabled by default in the CMakeLists.txt. For me, that's fine, but then it should compile. So either disable this feature in the CMakeLists.txt, or merge the pull request which is linked, so that the compilation gets fixed.

[ThomasDevoogdt]

Fixed by 4ab9331, please also read my comment here, fluent/cprofiles#3 (comment), a bit disappointing that contributions gets ignored.