Skip to content

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Jun 11, 2024

Added ability to set custom HTTP headers for Elasticsearch output


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
[INPUT]
    name              tail
    path              /var/lib/docker/containers/**/*.log
    path_key         path
    multiline.parser  docker, cri
    Parser docker
    Docker_Mode  On

[INPUT]
    Name     syslog
    Listen   0.0.0.0
    Port     5140
    Parser   syslog-rfc3164
    Mode     tcp

[SERVICE]
    Flush        1
    Parsers_File parsers.conf

[Output]
    Name es
    Match *
    host victorialogs
    port 9428
    compress gzip
    path /insert/elasticsearch
    header AccountID 0
    header ProjectID 0
    header VL-Stream-Fields path
    header VL-Msg-Field log
    header VL-Time-Field @timestamp
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

fluent/fluent-bit-docs#1390

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@AndrewChubatiuk
Copy link
Contributor Author

Hey @PettitWesley @edsiper
Could you please help with a review?

@patrick-stephens
Copy link
Collaborator

I'm looking to fix up the failures for CentOS 7 and Windows on 3.0 - these are down to changes outside of us (repo for CentOS and runners for Windows). They're already fixed on master.

@patrick-stephens
Copy link
Collaborator

See #9415, rebase once merged.

@AndrewChubatiuk AndrewChubatiuk changed the base branch from 3.0 to 3.1 September 24, 2024 12:39
@AndrewChubatiuk AndrewChubatiuk changed the base branch from 3.1 to master September 24, 2024 12:40
@AndrewChubatiuk AndrewChubatiuk force-pushed the out-es-custom-http-headers branch from 3b7beb3 to 346c09e Compare September 24, 2024 12:42
@patrick-stephens
Copy link
Collaborator

Which branch did you actually want @AndrewChubatiuk ? Might be easier to start a fresh PR :)

@AndrewChubatiuk AndrewChubatiuk force-pushed the out-es-custom-http-headers branch from 346c09e to 6ade471 Compare September 24, 2024 12:45
@AndrewChubatiuk AndrewChubatiuk force-pushed the out-es-custom-http-headers branch from 6ade471 to 7f83e4e Compare September 24, 2024 12:46
@AndrewChubatiuk
Copy link
Contributor Author

initially I've created PR against 3.0 thought it'll be merged fast enough, but did not expect it'll take so much time.
now I've rebased it against master with a hope it'll be merged eventually

@patrick-stephens
Copy link
Collaborator

It's a shame we cannot just inherit the http plugin support for this directly.

@AndrewChubatiuk
Copy link
Contributor Author

@patrick-stephens opened a fresh PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants