Skip to content

Commit 969b88d

Browse files
committed
Merge pull request #57 from fluent/fix_ci
Fix CI test failures
2 parents 0e21d8b + 74428ad commit 969b88d

File tree

4 files changed

+25
-4
lines changed

4 files changed

+25
-4
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ jdk:
55
- oraclejdk7
66
- oraclejdk8
77

8+
sudo: false
9+
810
branches:
911
only:
1012
- master

src/test/java/org/fluentd/logger/TestFluentLogger.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
7272

7373
FixedThreadManager threadManager = new FixedThreadManager(1);
7474
threadManager.submit(fluentd);
75+
fluentd.waitUntilReady();
7576

7677
// start loggers
7778
FluentLogger logger = FluentLogger.getLogger("testtag", host, port);
@@ -139,6 +140,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
139140
});
140141
FixedThreadManager threadManager = new FixedThreadManager(1);
141142
threadManager.submit(fluentd);
143+
fluentd.waitUntilReady();
142144

143145
// start loggers
144146
FluentLogger[] loggers = new FluentLogger[loggerCount];
@@ -229,6 +231,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
229231
}
230232
});
231233
threadManager.submit(fluentd1);
234+
fluentd1.waitUntilReady();
232235

233236
// start a logger
234237
final FluentLogger logger = FluentLogger.getLogger("testtag", host, port);
@@ -306,9 +309,8 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
306309
}
307310
});
308311
threadManager.submit(fluentd2);
312+
fluentd2.waitUntilReady();
309313

310-
// the logger should send an event successfully
311-
TimeUnit.MILLISECONDS.sleep(500);
312314
{
313315
Map<String, Object> data = new HashMap<String, Object>();
314316
data.put("k5", "v5");
@@ -400,7 +402,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
400402

401403
FixedThreadManager threadManager = new FixedThreadManager(1);
402404
threadManager.submit(fluentd);
403-
Thread.sleep(1000);
405+
fluentd.waitUntilReady();
404406

405407
final FluentLogger logger = FluentLogger.getLogger(null, host, port);
406408
ExecutorService executorService = Executors.newFixedThreadPool(N);
@@ -487,7 +489,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
487489
}
488490

489491
threadManager.submit(fluentd);
490-
Thread.sleep(1000);
492+
fluentd.waitUntilReady();
491493

492494
// close loggers and it should flush the buffer
493495
logger.close();

src/test/java/org/fluentd/logger/sender/TestRawSocketSender.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
5151
}
5252
});
5353
fluentd.start();
54+
fluentd.waitUntilReady();
5455

5556
// start senders
5657
Sender sender = new RawSocketSender("localhost", port);
@@ -113,6 +114,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
113114
}
114115
});
115116
fluentd.start();
117+
fluentd.waitUntilReady();
116118

117119
// start senders
118120
Sender sender = new RawSocketSender("localhost", port);
@@ -164,6 +166,8 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
164166
}
165167
});
166168
fluentds[0].start();
169+
fluentds[0].waitUntilReady();
170+
167171
ports[1] = MockFluentd.randomPort();
168172
elists[1] = new ArrayList<Event>();
169173
fluentds[1] = new MockFluentd(ports[1], new MockFluentd.MockProcess() {
@@ -182,6 +186,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
182186
}
183187
});
184188
fluentds[1].start();
189+
fluentds[1].waitUntilReady();
185190

186191
// start senders
187192
Sender[] senders = new Sender[2];
@@ -274,6 +279,7 @@ public void process(MessagePack msgpack, Socket socket) throws IOException {
274279

275280
MockFluentd fluentd = new MockFluentd(port, mockProcess);
276281
fluentd.start();
282+
fluentd.waitUntilReady();
277283

278284
Sender sender = new RawSocketSender("localhost", port);
279285
assertFalse(sender.isConnected());

src/test/java/org/fluentd/logger/util/MockFluentd.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,17 @@ public void run() {
148148
_logger.debug("Terminated MockFluentd port:" + serverSocket.getLocalPort());
149149
}
150150

151+
public void waitUntilReady()
152+
throws InterruptedException
153+
{
154+
int tick = 200;
155+
while (!started.get()) {
156+
TimeUnit.MILLISECONDS.sleep(tick);
157+
}
158+
// Just in case
159+
TimeUnit.MILLISECONDS.sleep(tick);
160+
}
161+
151162
public void close() throws IOException {
152163
finished.set(true);
153164
service.shutdown();

0 commit comments

Comments
 (0)