Skip to content

Commit 0ee3330

Browse files
authored
Merge pull request #1543 from sandy2008/patch-1
fix(crd): disallow null values for logfmt parser to prevent fluent-bit crash
2 parents c457939 + e3f8a50 commit 0ee3330

File tree

7 files changed

+25
-0
lines changed

7 files changed

+25
-0
lines changed

apis/fluentbit/v1alpha2/clusterparser_types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ type ParserSpec struct {
4242
// LTSV defines ltsv parser configuration.
4343
LTSV *parser.LSTV `json:"ltsv,omitempty"`
4444
// Logfmt defines logfmt parser configuration.
45+
// +kubebuilder:validation:XValidation:rule="self != null",message="logfmt must not be null"
4546
Logfmt *parser.Logfmt `json:"logfmt,omitempty"`
4647
// Decoders are a built-in feature available through the Parsers file, each Parser definition can optionally set one or multiple decoders.
4748
// There are two type of decoders type: Decode_Field and Decode_Field_As.

charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_clusterparsers.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ spec:
7575
logfmt:
7676
description: Logfmt defines logfmt parser configuration.
7777
type: object
78+
x-kubernetes-validations:
79+
- message: logfmt must not be null
80+
rule: self != null
7881
ltsv:
7982
description: LTSV defines ltsv parser configuration.
8083
properties:

charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_parsers.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ spec:
7575
logfmt:
7676
description: Logfmt defines logfmt parser configuration.
7777
type: object
78+
x-kubernetes-validations:
79+
- message: logfmt must not be null
80+
rule: self != null
7881
ltsv:
7982
description: LTSV defines ltsv parser configuration.
8083
properties:

config/crd/bases/fluentbit.fluent.io_clusterparsers.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ spec:
7575
logfmt:
7676
description: Logfmt defines logfmt parser configuration.
7777
type: object
78+
x-kubernetes-validations:
79+
- message: logfmt must not be null
80+
rule: self != null
7881
ltsv:
7982
description: LTSV defines ltsv parser configuration.
8083
properties:

config/crd/bases/fluentbit.fluent.io_parsers.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ spec:
7575
logfmt:
7676
description: Logfmt defines logfmt parser configuration.
7777
type: object
78+
x-kubernetes-validations:
79+
- message: logfmt must not be null
80+
rule: self != null
7881
ltsv:
7982
description: LTSV defines ltsv parser configuration.
8083
properties:

manifests/setup/fluent-operator-crd.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10977,6 +10977,9 @@ spec:
1097710977
logfmt:
1097810978
description: Logfmt defines logfmt parser configuration.
1097910979
type: object
10980+
x-kubernetes-validations:
10981+
- message: logfmt must not be null
10982+
rule: self != null
1098010983
ltsv:
1098110984
description: LTSV defines ltsv parser configuration.
1098210985
properties:
@@ -39807,6 +39810,9 @@ spec:
3980739810
logfmt:
3980839811
description: Logfmt defines logfmt parser configuration.
3980939812
type: object
39813+
x-kubernetes-validations:
39814+
- message: logfmt must not be null
39815+
rule: self != null
3981039816
ltsv:
3981139817
description: LTSV defines ltsv parser configuration.
3981239818
properties:

manifests/setup/setup.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10977,6 +10977,9 @@ spec:
1097710977
logfmt:
1097810978
description: Logfmt defines logfmt parser configuration.
1097910979
type: object
10980+
x-kubernetes-validations:
10981+
- message: logfmt must not be null
10982+
rule: self != null
1098010983
ltsv:
1098110984
description: LTSV defines ltsv parser configuration.
1098210985
properties:
@@ -39807,6 +39810,9 @@ spec:
3980739810
logfmt:
3980839811
description: Logfmt defines logfmt parser configuration.
3980939812
type: object
39813+
x-kubernetes-validations:
39814+
- message: logfmt must not be null
39815+
rule: self != null
3981039816
ltsv:
3981139817
description: LTSV defines ltsv parser configuration.
3981239818
properties:

0 commit comments

Comments
 (0)