Skip to content

msi: show checkbox to guide release note #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kenhys merged 1 commit into from
Jun 6, 2025
Merged

msi: show checkbox to guide release note #848

kenhys merged 1 commit into from
Jun 6, 2025

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented May 30, 2025 •
edited
Loading

@kenhys kenhys force-pushed the msi-well-done branch 3 times, most recently from 45ffdfc to c2763e8 Compare May 30, 2025 08:21
@kenhys
Copy link
Contributor Author

kenhys commented May 30, 2025 

Action ended 17:12:04: CreateCompatTdAgentGemBat. Return value 1.
MSI (s) (40:60) [17:12:04:941]: Doing action: SetFluentPackageReleaseNote
MSI (s) (40:60) [17:12:04:941]: Note: 1: 2205 2:  3: ActionText 
Action 17:12:04: SetFluentPackageReleaseNote. 
Action start 17:12:04: SetFluentPackageReleaseNote.
MSI (s) (40:60) [17:12:04:941]: PROPERTY CHANGE: Modifying FluentPackageReleaseNote property. Its current value is ' '. Its new value: 'https://github.com/fluent/fluent-package-builder/releases/tag/v5.2.0'.
Action ended 17:12:04: SetFluentPackageReleaseNote. Return value 1.
MSI (s) (40:60) [17:12:04:941]: Doing action: SetExitDialogDescription
MSI (s) (40:60) [17:12:04:941]: Note: 1: 2205 2:  3: ActionText 
Action 17:12:04: SetExitDialogDescription. 
Action start 17:12:04: SetExitDialogDescription.
MSI (s) (40:60) [17:12:04:941]: PROPERTY CHANGE: Adding WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT property. Its value is 'Visit Fluent Package v5.2.0 5.2.0 release note'.
Action ended 17:12:04: SetExitDialogDescription. Return value 1.
MSI (s) (40:60) [17:12:04:941]: Doing action: PostVisitReleaseNote
MSI (s) (40:60) [17:12:04:941]: Note: 1: 2205 2:  3: ActionText 
Action 17:12:04: PostVisitReleaseNote. 
Action start 17:12:04: PostVisitReleaseNote.
MSI (s) (40:60) [17:12:04:941]: Doing action: InstallFinalize
MSI (s) (40:60) [17:12:04:941]: Note: 1: 2205 2:  3: ActionText 
Action 17:12:04: InstallFinalize. 
MSI (s) (40:90) [17:12:04:941]: System Environment : Client has accepted UAC prompt
Action ended 17:12:04: PostVisitReleaseNote. Return value 1631.
Action start 17:12:04: InstallFinalize.

FluentPackageReleaseNote was correctly set,
WIXUI_EXITDIALOGOPTIONALCHECKBOXTEXT should be tweaked.

@kenhys kenhys force-pushed the msi-well-done branch 5 times, most recently from 0daf1e4 to fee481a Compare June 4, 2025 07:16
@kenhys
Copy link
Contributor Author

kenhys commented Jun 4, 2025

Expected:

image

When msiexec /quiet /i fluent-package-5.2.0-x64.msi with admin privileged, the above dialog will not be shown.

@kenhys kenhys requested review from Watson1978 and daipom June 4, 2025 07:19
@kenhys kenhys marked this pull request as ready for review June 4, 2025 07:19
@kenhys
Copy link
Contributor Author

kenhys commented Jun 4, 2025

Now it will work!

@kenhys
msi: show checkbox to guide release note
1832e2d 
See

https://docs.firegiant.com/wix3/wixui/wixui_customizations/
https://docs.firegiant.com/wix3/tutorial/net-and-net/launch-the-internet/

Note that CustomAction with WixQuietExec64 or Property and ExeCommand
with asyncNowait wouldn't worked, so use ExeCommand with
Directory=TARGETDIR.

Signed-off-by: Kentaro Hayashi <[email protected]>
Watson1978
Watson1978 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kenhys kenhys merged commit f13df64 into fluent:master Jun 6, 2025
255 of 256 checks passed
@kenhys kenhys deleted the msi-well-done branch June 6, 2025 00:59
@Watson1978 Watson1978 added this to the 6.0.0 milestone Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Watson1978 Watson1978 Watson1978 approved these changes

@daipom daipom Awaiting requested review from daipom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kenhys @Watson1978