Skip to content

Commit 3d63b3f

Browse files
committed
Moving required gems into gemspec
1 parent 23edf22 commit 3d63b3f

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

Gemfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,3 @@ source 'https://rubygems.org'
22

33
# Specify your gem's dependencies in fluent-plugin-kafka.gemspec
44
gemspec
5-
6-
if ENV['USE_RDKAFKA']
7-
gem 'rdkafka', ENV['RDKAFKA_VERSION_MIN_RANGE'], ENV['RDKAFKA_VERSION_MAX_RANGE']
8-
min_version = Gem::Version.new('0.16.0')
9-
min_range_version = Gem::Version.new(ENV['RDKAFKA_VERSION_MIN_RANGE'].split(' ').last)
10-
if min_range_version >= min_version
11-
gem 'aws-msk-iam-sasl-signer'
12-
gem 'json', '2.7.3' # override of 2.7.4 version
13-
end
14-
end

fluent-plugin-kafka.gemspec

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,12 @@ Gem::Specification.new do |gem|
1919
gem.add_dependency "fluentd", [">= 0.10.58", "< 2"]
2020
gem.add_dependency 'ltsv'
2121
gem.add_dependency 'ruby-kafka', '>= 1.5.0', '< 2'
22+
23+
if ENV['USE_RDKAFKA']
24+
gem.add_dependency 'rdkafka', [ENV['RDKAFKA_VERSION_MIN_RANGE'], ENV['RDKAFKA_VERSION_MAX_RANGE']]
25+
gem.add_dependency 'aws-msk-iam-sasl-signer', '~> 0.1.1'
26+
end
27+
2228
gem.add_development_dependency "rake", ">= 0.9.2"
2329
gem.add_development_dependency "test-unit", ">= 3.0.8"
2430
gem.add_development_dependency "test-unit-rr", "~> 1.0"

lib/fluent/plugin/out_rdkafka2.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
require_relative 'rdkafka_patch/0_14_0'
1616
elsif rdkafka_version >= Gem::Version.create('0.16.0')
1717
require_relative 'rdkafka_patch/0_16_0'
18-
require 'aws_msk_iam_sasl_signer'
1918
end
19+
require 'aws_msk_iam_sasl_signer' if rdkafka_version >= Gem::Version.create('0.16.0')
2020
rescue LoadError, NameError
2121
raise "unable to patch rdkafka."
2222
end

0 commit comments

Comments
 (0)