Skip to content

Commit c966002

Browse files
authored
Merge pull request #2 from madebydna/aws_msk_iam_improvements
Fixing CI failures with Ruby 2.7
2 parents ed87e48 + a0fac67 commit c966002

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

Gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,3 @@ source 'https://rubygems.org'
22

33
# Specify your gem's dependencies in fluent-plugin-kafka.gemspec
44
gemspec
5-
6-
gem 'json', '2.7.3' # override of 2.7.4 version
7-
gem 'rdkafka', ENV['RDKAFKA_VERSION_MIN_RANGE'], ENV['RDKAFKA_VERSION_MAX_RANGE'] if ENV['USE_RDKAFKA']

fluent-plugin-kafka.gemspec

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,14 @@ Gem::Specification.new do |gem|
1919
gem.add_dependency "fluentd", [">= 0.10.58", "< 2"]
2020
gem.add_dependency 'ltsv'
2121
gem.add_dependency 'ruby-kafka', '>= 1.5.0', '< 2'
22-
gem.add_dependency 'rdkafka'
23-
gem.add_dependency 'aws-msk-iam-sasl-signer'
22+
23+
if ENV['USE_RDKAFKA']
24+
gem.add_dependency 'rdkafka', [ENV['RDKAFKA_VERSION_MIN_RANGE'], ENV['RDKAFKA_VERSION_MAX_RANGE']]
25+
if Gem::Version.new('3.0' >= Gem::Version.new(RUBY_VERSION)
26+
gem.add_dependency 'aws-msk-iam-sasl-signer', '~> 0.1.1'
27+
end
28+
end
29+
2430
gem.add_development_dependency "rake", ">= 0.9.2"
2531
gem.add_development_dependency "test-unit", ">= 3.0.8"
2632
gem.add_development_dependency "test-unit-rr", "~> 1.0"

lib/fluent/plugin/out_rdkafka2.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
require 'fluent/plugin/kafka_plugin_util'
55

66
require 'rdkafka'
7-
require 'aws_msk_iam_sasl_signer'
87

98
begin
109
rdkafka_version = Gem::Version::create(Rdkafka::VERSION)
@@ -21,6 +20,10 @@
2120
raise "unable to patch rdkafka."
2221
end
2322

23+
if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('3.0')
24+
require 'aws-msk-iam-sasl-signer'
25+
end
26+
2427
module Fluent::Plugin
2528
class Fluent::Rdkafka2Output < Output
2629
Fluent::Plugin.register_output('rdkafka2', self)
@@ -208,7 +211,6 @@ def add(level, message = nil)
208211
end
209212
end
210213
}
211-
# HERE -----------------
212214
Rdkafka::Config.logger = log
213215
config = build_config
214216
@rdkafka = Rdkafka::Config.new(config)
@@ -217,7 +219,6 @@ def add(level, message = nil)
217219
if config[:"security.protocol"] == "sasl_ssl" && config[:"sasl.mechanisms"] == "OAUTHBEARER"
218220
Rdkafka::Config.oauthbearer_token_refresh_callback = method(:refresh_token)
219221
end
220-
# HERE -----------------
221222

222223
if @default_topic.nil?
223224
if @use_default_for_unknown_topic || @use_default_for_unknown_partition_error

0 commit comments

Comments
 (0)