Skip to content

Commit bbf5d7a

Browse files
committed
Added bucket name to object returned by sqs poller in the unit tests
Fixed wrong variable name in the input plugin
1 parent 54e7b79 commit bbf5d7a

File tree

2 files changed

+27
-3
lines changed

2 files changed

+27
-3
lines changed

lib/fluent/plugin/in_s3.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ def start
156156
raise "#{bucket} is not found." unless @buckets[bucket].exists?
157157
end
158158
else
159-
@buckets[bucket] = @s3.bucket(@s3_buckets)
160-
raise "#{bucket} is not found." unless @buckets[bucket].exists?
159+
@buckets[@s3_buckets] = @s3.bucket(@s3_buckets)
160+
raise "#{@s3_buckets} is not found." unless @buckets[@s3_buckets].exists?
161161
end
162162

163163
check_apikeys if @check_apikey_on_start

test/test_in_s3.rb

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ def setup_mocks
228228
mock(Aws::S3::Client).new(anything).at_least(0) { @s3_client }
229229
@s3_resource = mock(Aws::S3::Resource.new(client: @s3_client))
230230
mock(Aws::S3::Resource).new(client: @s3_client) { @s3_resource }
231-
@s3_bucket = mock(Aws::S3::Bucket.new(name: "test",
231+
@s3_bucket = mock(Aws::S3::Bucket.new(name: "test_bucket",
232232
client: @s3_client))
233233
@s3_bucket.exists? { true }
234234
@s3_resource.bucket(anything) { @s3_bucket }
@@ -278,6 +278,9 @@ def test_one_record
278278
"s3" => {
279279
"object" => {
280280
"key" => "test_key"
281+
},
282+
"bucket" => {
283+
"name"=> "test_bucket"
281284
}
282285
}
283286
}
@@ -313,6 +316,9 @@ def test_one_record_with_metadata
313316
"s3" => {
314317
"object" => {
315318
"key" => "test_key"
319+
},
320+
"bucket" => {
321+
"name"=> "test_bucket"
316322
}
317323
}
318324
}
@@ -348,6 +354,9 @@ def test_one_record_url_encoded
348354
"s3" => {
349355
"object" => {
350356
"key" => "test+key"
357+
},
358+
"bucket" => {
359+
"name"=> "test_bucket"
351360
}
352361
}
353362
}
@@ -383,6 +392,9 @@ def test_one_record_url_encoded_with_metadata
383392
"s3" => {
384393
"object" => {
385394
"key" => "test+key"
395+
},
396+
"bucket" => {
397+
"name"=> "test_bucket"
386398
}
387399
}
388400
}
@@ -418,6 +430,9 @@ def test_one_record_multi_line
418430
"s3" => {
419431
"object" => {
420432
"key" => "test_key"
433+
},
434+
"bucket" => {
435+
"name"=> "test_bucket"
421436
}
422437
}
423438
}
@@ -458,6 +473,9 @@ def test_one_record_multi_line_with_metadata
458473
"s3" => {
459474
"object" => {
460475
"key" => "test_key"
476+
},
477+
"bucket" => {
478+
"name"=> "test_bucket"
461479
}
462480
}
463481
}
@@ -506,6 +524,9 @@ def test_gzip_single_stream
506524
"s3" => {
507525
"object" => {
508526
"key" => "test_key"
527+
},
528+
"bucket" => {
529+
"name"=> "test_bucket"
509530
}
510531
}
511532
}
@@ -557,6 +578,9 @@ def test_gzip_multiple_steams
557578
"s3" => {
558579
"object" => {
559580
"key" => "test_key"
581+
},
582+
"bucket" => {
583+
"name"=> "test_bucket"
560584
}
561585
}
562586
}

0 commit comments

Comments
 (0)