Question in fluent-s3-plugin's instance_profile_credentials documentation

[fumihumi]

I was wondering about the behavior of instance_profile_credentials in document while using fluent-plugin-s3 (https://github.com/fluent/fluent-plugin-s3 ).

The instance_profile_credentials documentation (reference: https://github.com/fluent/fluent-plugin-s3/blob/master/docs/credentials.md#instance_ profile _credentials-section) says "Number of times to retry when retrieving credentials. Default is 5."

However, plugin/out_s3.rb: https://github.com/fluent/fluent-plugin-s3/blob/ae08e3be1149dc747b796c29007d9cf5e68b23ed/lib/fluent/plugin/out_s3.rb#L66-L68
plugin/in_s3.rb: https://github.com/fluent/fluent-plugin-s3/blob/ae08e3be1149dc747b796c29007d9cf5e68b23ed/lib/fluent/plugin/in_s3.rb#L59-L61

In the above, default: nil seems to be set.

The default value for aws-sdk-ruby also appears to be retries: 1.
https://github.com/aws/aws-sdk-ruby/blob/425e913bc65488495d4b0c01f8f8c1ce67d18823/gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb#L75-L89

I could not find the implementation of the number 5.

Is the Document out of date? Or is the implementation wrong?

Thank you.

[fumihumi]

aws_iam_retries is already deprecated, but I traced the commit log for this line and found the following commit.

config_param :aws_iam_retries, :integer, default: nil, deprecated: "Use 'instance_profile_credentials' instead."

ref: https://github.com/fluent/fluent-plugin-s3/blame/master/lib/fluent/plugin/out_s3.rb#L87

commit: fluent/fluent-plugin-s3@11e8ad7

I seem to have forgotten to update the documentation, is that right?
I have created a PR for updating the documentation, and will close this discussion once I have confirmation from the PR.
fluent/fluent-plugin-s3#426

[fumihumi]

This discussion is closed due to updated documentation by fluent/fluent-plugin-s3#426.