From ebeef79cb23d57e119f4b84d9bf38e1420776d8c Mon Sep 17 00:00:00 2001 From: Paul Fawkesley Date: Tue, 21 May 2019 18:17:01 +0100 Subject: [PATCH] improve error log output --- server/json.go | 2 +- server/teamshandler.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/server/json.go b/server/json.go index 6a515dd..ee58491 100644 --- a/server/json.go +++ b/server/json.go @@ -21,7 +21,7 @@ func writeJsonResponse(w http.ResponseWriter, responseData interface{}) { } func writeJsonError(w http.ResponseWriter, err error, statusCode int) { - log.Print(err) + log.Printf("http %d: %v", statusCode, err) responseData := v1structs.ErrorResponse{Detail: err.Error()} out, err := json.MarshalIndent(responseData, "", " ") diff --git a/server/teamshandler.go b/server/teamshandler.go index 2fbec66..15cd1a2 100644 --- a/server/teamshandler.go +++ b/server/teamshandler.go @@ -90,6 +90,9 @@ func upsertTeamHandler(w http.ResponseWriter, r *http.Request) { meInExistingTeam, err := existingTeam.GetPersonForFingerprint(apparentSignerKey.Fingerprint()) if err != nil || !meInExistingTeam.IsAdmin { + log.Printf("key %s tried to update team %s but is not an admin: %v", + apparentSignerKey.Fingerprint(), existingTeam.UUID, err) + return errNotAnAdminInExistingTeam }