fix: Fix performance when refreshing news

Whenever we inserted a link in the news, we synchronised the publication
frequency. This had a critical impact on performance.

Commit introducing the issue: c189583

Author: marienfressinaud

src/models/Journal.php

@@ -45,7 +45,11 @@ public function fill(int $max): int
             $link->save();
 
             // And don't forget to add the link to the news collection!
-            $link->addCollection($news, at: $news_link->published_at);
+            $link->addCollection(
+                $news,
+                at: $news_link->published_at,
+                sync_publication_frequency: false,
+            );
         }
 
         Link::groupLinksBySources($news->id);

src/models/Link.php

@@ -202,14 +202,19 @@ public function collections(): array
      *
      * @param Collection[] $collections
      */
-    public function setCollections(array $collections, ?\DateTimeImmutable $at = null): void
-    {
+    public function setCollections(
+        array $collections,
+        ?\DateTimeImmutable $at = null,
+        bool $sync_publication_frequency = true,
+    ): void {
         $collection_ids = array_column($collections, 'id');
         LinkToCollection::setCollections($this->id, $collection_ids, $at);
 
-        foreach ($collections as $collection) {
-            $collection->syncPublicationFrequencyPerYear();
-            $collection->save();
+        if ($sync_publication_frequency) {
+            foreach ($collections as $collection) {
+                $collection->syncPublicationFrequencyPerYear();
+                $collection->save();
+            }
         }
     }
 
@@ -218,47 +223,61 @@ public function setCollections(array $collections, ?\DateTimeImmutable $at = nul
      *
      * @param Collection[] $collections
      */
-    public function addCollections(array $collections, ?\DateTimeImmutable $at = null): void
-    {
+    public function addCollections(
+        array $collections,
+        ?\DateTimeImmutable $at = null,
+        bool $sync_publication_frequency = true,
+    ): void {
         $collection_ids = array_column($collections, 'id');
         LinkToCollection::attach([$this->id], $collection_ids, $at);
 
-        foreach ($collections as $collection) {
-            $collection->syncPublicationFrequencyPerYear();
-            $collection->save();
+        if ($sync_publication_frequency) {
+            foreach ($collections as $collection) {
+                $collection->syncPublicationFrequencyPerYear();
+                $collection->save();
+            }
         }
     }
 
     /**
      * Add the link to a collection.
      */
-    public function addCollection(Collection $collection, ?\DateTimeImmutable $at = null): void
-    {
-        $this->addCollections([$collection], $at);
+    public function addCollection(
+        Collection $collection,
+        ?\DateTimeImmutable $at = null,
+        bool $sync_publication_frequency = true,
+    ): void {
+        $this->addCollections([$collection], $at, $sync_publication_frequency);
     }
 
     /**
      * Remove the link from the collections.
      *
      * @param Collection[] $collections
      */
-    public function removeCollections(array $collections): void
-    {
+    public function removeCollections(
+        array $collections,
+        bool $sync_publication_frequency = true,
+    ): void {
         $collection_ids = array_column($collections, 'id');
         LinkToCollection::detach([$this->id], $collection_ids);
 
-        foreach ($collections as $collection) {
-            $collection->syncPublicationFrequencyPerYear();
-            $collection->save();
+        if ($sync_publication_frequency) {
+            foreach ($collections as $collection) {
+                $collection->syncPublicationFrequencyPerYear();
+                $collection->save();
+            }
         }
     }
 
     /**
      * Remove the link from a collection.
      */
-    public function removeCollection(Collection $collection): void
-    {
-        $this->removeCollections([$collection]);
+    public function removeCollection(
+        Collection $collection,
+        bool $sync_publication_frequency = true,
+    ): void {
+        $this->removeCollections([$collection], $sync_publication_frequency);
     }
 
     /**