fix: Make sure that links and feeds are saved in database

Usually, the fetch services save the models. Except when rate limiting
is reached. In that case, the link may not be created in the database.
It generated fatal errors on the API

Author: marienfressinaud

src/controllers/Links.php

@@ -213,6 +213,7 @@ public function create(Request $request): Response
                 'ignore_rate_limit' => true,
             ]);
             $link_fetcher_service->fetch($link);
+            $link->save();
         }
 
         $link_collections = $form->selectedCollections();

src/controllers/collections/Links.php

@@ -101,6 +101,7 @@ public function create(Request $request): Response
                 'ignore_rate_limit' => true,
             ]);
             $link_fetcher_service->fetch($link);
+            $link->save();
         }
 
         $link->addCollection($collection);

src/controllers/links/Repairing.php

@@ -99,6 +99,7 @@ public function create(Request $request): Response
             'force_sync' => $form->force_sync,
         ]);
         $link_fetcher_service->fetch($link);
+        $link->save();
 
         // Add the old link to the never list. It avoids to a link coming from
         // the news to reappear.

src/controllers/links/Searches.php

@@ -78,12 +78,14 @@ public function create(Request $request): Response
         $link = $form->link();
         if (!$link->isPersisted()) {
             $link_fetcher_service->fetch($link);
+            $link->save();
         }
 
         $feeds = $form->feeds();
         foreach ($feeds as $feed) {
             if (!$feed->isPersisted()) {
                 $feed_fetcher_service->fetch($feed);
+                $feed->save();
             }
         }
 

src/forms/api/Search.php

@@ -4,6 +4,7 @@
 
 use App\models;
 use App\services;
+use App\utils;
 use Minz\Form;
 use Minz\Validable;
 
@@ -13,18 +14,15 @@
  */
 class Search extends Form
 {
+    use utils\Memoizer;
+
     #[Form\Field(transform: '\SpiderBits\Url::sanitize')]
     #[Validable\Presence(message: 'The link is required.')]
     #[Validable\Url(message: 'The link is invalid.')]
     public string $url = '';
 
     private models\User $user;
 
-    private ?models\Link $cached_link = null;
-
-    /** @var ?models\Collection[] */
-    private ?array $cached_feeds = null;
-
     public function __construct(models\User $user)
     {
         parent::__construct();
@@ -34,59 +32,43 @@ public function __construct(models\User $user)
 
     public function link(): models\Link
     {
-        if ($this->cached_link !== null) {
-            return $this->cached_link;
-        }
-
-        $link = models\Link::findBy([
-            'user_id' => $this->user->id,
-            'url_hash' => models\Link::hashUrl($this->url),
-        ]);
-
-        if (!$link) {
-            $link = new models\Link($this->url, $this->user->id);
-
-            $link_fetcher_service = new services\LinkFetcher();
-            $link_fetcher_service->fetch($link);
-        }
+        return $this->memoize('link', function (): models\Link {
+            $link = $this->user->findOrBuildLink($this->url);
 
-        $this->cached_link = $link;
+            if (!$link->isPersisted()) {
+                $link_fetcher_service = new services\LinkFetcher();
+                $link_fetcher_service->fetch($link);
+                $link->save();
+            }
 
-        return $link;
+            return $link;
+        });
     }
 
     /**
      * @return models\Collection[]
      */
     public function feeds(): array
     {
-        if ($this->cached_feeds !== null) {
-            return $this->cached_feeds;
-        }
-
-        $link = $this->link();
-        $feeds = [];
-
-        $support_user = models\User::supportUser();
-        $feed_fetcher_service = new services\FeedFetcher();
-
-        foreach ($link->url_feeds as $feed_url) {
-            $feed = models\Collection::findBy([
-                'type' => 'feed',
-                'feed_url' => $feed_url,
-                'user_id' => $support_user->id,
-            ]);
-
-            if (!$feed) {
-                $feed = models\Collection::initFeed($support_user->id, $feed_url);
-                $feed_fetcher_service->fetch($feed);
-            }
+        return $this->memoize('feeds', function (): array {
+            $link = $this->link();
+            $feeds = [];
+
+            $support_user = models\User::supportUser();
+            $feed_fetcher_service = new services\FeedFetcher();
 
-            $feeds[] = $feed;
-        }
+            foreach ($link->url_feeds as $feed_url) {
+                $feed = models\Collection::findOrBuildFeed($feed_url);
 
-        $this->cached_feeds = $feeds;
+                if (!$feed->isPersisted()) {
+                    $feed_fetcher_service->fetch($feed);
+                    $feed->save();
+                }
+
+                $feeds[] = $feed;
+            }
 
-        return $feeds;
+            return $feeds;
+        });
     }
 }

src/forms/collections/NewFeed.php

@@ -53,6 +53,7 @@ public function setAutodiscovering(Request $request): void
             'ignore_rate_limit' => true,
         ]);
         $link_fetcher_service->fetch($link);
+        $link->save();
 
         $this->autodiscovering_link = $link;
     }