Skip to content
This repository was archived by the owner on Aug 24, 2020. It is now read-only.

Commit 13bfd7e

Browse files
Fix: fix stack.destroyCard
1 parent 4b4c968 commit 13bfd7e

File tree

4 files changed

+16
-5
lines changed

4 files changed

+16
-5
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
<a name="2.2.2"></a>
2+
## [2.2.2](https://github.com/peterpeterparker/ionic-swing/compare/v2.2.1...v2.2.2) (2018-08-18)
3+
* **fix**: `stack.destroyCard` was wrongly implemented
4+
* **feature**: Observe `prepend` option in `stack.destroyCard`
5+
16
<a name="2.2.1"></a>
27
## [2.2.1](https://github.com/peterpeterparker/ionic-swing/compare/v2.2.0...v2.2.1) (2018-08-18)
38
* **fix**: Remove import of `hammerjs` (see README or CHANGELOG v2.1.0)

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ionic-swing",
3-
"version": "2.2.1",
3+
"version": "2.2.2",
44
"license": "MIT",
55
"scripts": {
66
"ng": "ng",

src/app/modules/ionic-swing/swing/stack.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,15 @@ export const Stack = (config) => {
119119
stack.destroyCard = (card) => {
120120
eventEmitter.trigger('destroyCard', card);
121121

122-
return _.remove(index, {
123-
card
124-
});
122+
if (index && config.sortCards) {
123+
if (config.prependCards) {
124+
index.shift();
125+
} else {
126+
index.pop();
127+
}
128+
}
129+
130+
return index;
125131
};
126132

127133
return stack;

0 commit comments

Comments
 (0)